test for SoundFileSystemError instead of RuntimeError

check for backward-compatibility too, though (catching RuntimeError must
still work)

Author: Jajcus

tests/test_pysoundfile.py

@@ -232,11 +232,12 @@ def test_read_mono_into_2d_out(file_mono_r):
 
 
 def test_read_non_existing_file():
-    with pytest.raises(RuntimeError) as excinfo:
+    with pytest.raises(sf.SoundFileError) as excinfo:
         sf.read("i_do_not_exist.wav")
     assert "Error opening 'i_do_not_exist.wav'" in str(excinfo.value)
 
 
+
 # -----------------------------------------------------------------------------
 # Test write() function
 # -----------------------------------------------------------------------------
@@ -418,7 +419,7 @@ def test_blocks_wplus(sf_stereo_wplus):
 
 
 def test_blocks_write(sf_stereo_w):
-    with pytest.raises(RuntimeError):
+    with pytest.raises(sf.SoundFileError):
         list(sf_stereo_w.blocks(blocksize=2))
 
 
@@ -644,9 +645,9 @@ def test_seek_in_read_mode(sf_stereo_r):
     assert sf_stereo_r.tell() == 2
     assert sf_stereo_r.seek(2, sf.SEEK_CUR) == 4
     assert sf_stereo_r.seek(-2, sf.SEEK_END) == len(data_stereo) - 2
-    with pytest.raises(RuntimeError):
+    with pytest.raises(sf.SoundFileError):
         sf_stereo_r.seek(666)
-    with pytest.raises(RuntimeError):
+    with pytest.raises(sf.SoundFileError):
         sf_stereo_r.seek(-666)
 
 
@@ -685,8 +686,9 @@ def test_truncate(file_stereo_rplus, use_default):
     else:
         # file objects don't support truncate()
         with sf.SoundFile(file_stereo_rplus, 'r+', closefd=False) as f:
-            with pytest.raises(RuntimeError) as excinfo:
+            with pytest.raises(sf.SoundFileError) as excinfo:
                 f.truncate()
+            assert isinstance(excinfo.value, RuntimeError)
             assert "Error truncating" in str(excinfo.value)
 
 
@@ -696,7 +698,7 @@ def test_truncate(file_stereo_rplus, use_default):
 
 
 def test_read_write_only(sf_stereo_w):
-    with pytest.raises(RuntimeError):
+    with pytest.raises(sf.SoundFileError):
         sf_stereo_w.read(2)
 
 
@@ -796,7 +798,7 @@ def test_buffer_read_into(sf_stereo_r):
 
 
 def test_write_to_read_only_file_should_fail(sf_stereo_r):
-    with pytest.raises(RuntimeError):
+    with pytest.raises(sf.SoundFileError):
         sf_stereo_r.write(data_stereo)
 
 
@@ -887,8 +889,9 @@ def test_closing_should_close_file(file_stereo_r):
 def test_anything_on_closed_file(file_stereo_r):
     with sf.SoundFile(file_stereo_r) as f:
         pass
-    with pytest.raises(RuntimeError) as excinfo:
+    with pytest.raises(sf.SoundFileError) as excinfo:
         f.seek(0)
+    assert isinstance(excinfo.value, RuntimeError)
     assert "closed" in str(excinfo.value)
 
 
@@ -1014,8 +1017,9 @@ def test_write_non_seekable_file(file_w):
         f.write(data_mono)
         assert f.frames == len(data_mono)
 
-        with pytest.raises(RuntimeError) as excinfo:
+        with pytest.raises(sf.SoundFileError) as excinfo:
             f.seek(2)
+        assert isinstance(excinfo.value, RuntimeError)
         assert "unseekable" in str(excinfo.value)
 
     with sf.SoundFile(filename_new) as f:
@@ -1026,8 +1030,9 @@ def test_write_non_seekable_file(file_w):
         data = f.read(666, dtype='int16')
         assert np.all(data == data_mono[3:])
 
-        with pytest.raises(RuntimeError) as excinfo:
+        with pytest.raises(sf.SoundFileError) as excinfo:
             f.seek(2)
+        assert isinstance(excinfo.value, RuntimeError)
         assert "unseekable" in str(excinfo.value)
 
         with pytest.raises(ValueError) as excinfo:
@@ -1041,3 +1046,32 @@ def test_write_non_seekable_file(file_w):
     with pytest.raises(ValueError) as excinfo:
         sf.read(filename_new, start=3)
     assert "start is only allowed for seekable files" in str(excinfo.value)
+
+
+# -----------------------------------------------------------------------------
+# Test LibsndfileError
+# -----------------------------------------------------------------------------
+
+def test_libsndfile_error():
+    err = sf.LibsndfileError(2)
+    assert isinstance(err, sf.SoundFileError)
+    assert err.error_string # cannot assume exact message generated by libsndfile
+    assert str(err) == err.error_string
+
+def test_libsndfile_error_with_prefix():
+    err = sf.LibsndfileError(2, prefix="XX ")
+    assert isinstance(err, sf.SoundFileError)
+    assert err.error_string # cannot assume exact message generated by libsndfile
+    assert str(err) == "XX " + err.error_string
+
+def test_rasing_libsndfile_error():
+    with pytest.raises(sf.LibsndfileError) as excinfo:
+        sf.read("i_do_not_exist.wav")
+    assert isinstance(excinfo.value, sf.SoundFileError)
+    assert isinstance(excinfo.value, RuntimeError)
+    assert excinfo.value.code == 2 # SF_ERR_SYSTEM
+    if sys.version_info[0] == 2:
+        assert isinstance(excinfo.value.error_string, unicode)
+    else:
+        assert isinstance(excinfo.value.error_string, str)
+    assert excinfo.value.error_string in str(excinfo.value)