Skip to content

Commit c6730b2

Browse files
tanvi-jagtapcopybara-github
authored andcommitted
[PH2][Trivial][BUILD] Adding log (grpc#38800)
[PH2][Trivial][BUILD] Adding log Adding logs were I debug frequently. It is annoying to add it manually each time I need to debug in a new workspace. Eventually debugging and debuggability code will be added to all these critical files. Better to reduce time waste of adding log to dependencies each time I am just trying to see a LOG statement. Closes grpc#38800 COPYBARA_INTEGRATE_REVIEW=grpc#38800 from tanvi-jagtap:add_log_where_i_need 5b70f81 PiperOrigin-RevId: 730301757
1 parent 2fbc586 commit c6730b2

File tree

3 files changed

+29
-4
lines changed

3 files changed

+29
-4
lines changed

src/core/BUILD

+12
Original file line numberDiff line numberDiff line change
@@ -7472,6 +7472,7 @@ grpc_cc_library(
74727472
],
74737473
external_deps = [
74747474
"absl/functional:function_ref",
7475+
"absl/log",
74757476
"absl/strings",
74767477
],
74777478
deps = [
@@ -7490,6 +7491,10 @@ grpc_cc_library(
74907491
hdrs = [
74917492
"ext/transport/chttp2/transport/http2_client_transport.h",
74927493
],
7494+
external_deps = [
7495+
"absl/log",
7496+
"absl/log:check",
7497+
],
74937498
deps = [
74947499
"grpc_promise_endpoint",
74957500
"//:grpc_base",
@@ -7506,6 +7511,10 @@ grpc_cc_library(
75067511
hdrs = [
75077512
"ext/transport/chttp2/transport/http2_server_transport.h",
75087513
],
7514+
external_deps = [
7515+
"absl/log",
7516+
"absl/log:check",
7517+
],
75097518
deps = [
75107519
"grpc_promise_endpoint",
75117520
"//:grpc_base",
@@ -8676,6 +8685,7 @@ grpc_cc_library(
86768685
],
86778686
external_deps = [
86788687
"absl/base:core_headers",
8688+
"absl/log",
86798689
"absl/log:check",
86808690
"absl/status",
86818691
"absl/status:statusor",
@@ -8887,6 +8897,7 @@ grpc_cc_library(
88878897
],
88888898
external_deps = [
88898899
"absl/functional:any_invocable",
8900+
"absl/log",
88908901
"absl/log:check",
88918902
],
88928903
deps = [
@@ -8944,6 +8955,7 @@ grpc_cc_library(
89448955
"absl/container:flat_hash_set",
89458956
"absl/container:inlined_vector",
89468957
"absl/functional:function_ref",
8958+
"absl/log",
89478959
"absl/log:check",
89488960
"absl/meta:type_traits",
89498961
"absl/strings",

test/core/transport/chttp2/BUILD

+9-2
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,10 @@ grpc_cc_test(
490490
grpc_cc_test(
491491
name = "http2_client_transport_test",
492492
srcs = ["http2_client_transport_test.cc"],
493-
external_deps = ["gtest"],
493+
external_deps = [
494+
"absl/log:log",
495+
"gtest",
496+
],
494497
uses_polling = False,
495498
deps = [
496499
"//:gpr",
@@ -506,7 +509,10 @@ grpc_cc_test(
506509
grpc_cc_test(
507510
name = "http2_server_transport_test",
508511
srcs = ["http2_server_transport_test.cc"],
509-
external_deps = ["gtest"],
512+
external_deps = [
513+
"absl/log:log",
514+
"gtest",
515+
],
510516
uses_polling = False,
511517
deps = [
512518
"//:gpr",
@@ -575,6 +581,7 @@ grpc_cc_library(
575581
testonly = 1,
576582
hdrs = ["http2_frame_test_helper.h"],
577583
external_deps = [
584+
"absl/log:log",
578585
"absl/strings",
579586
"absl/types:span",
580587
],

test/core/transport/util/BUILD

+8-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@ grpc_cc_library(
2626
testonly = 1,
2727
srcs = ["mock_promise_endpoint.cc"],
2828
hdrs = ["mock_promise_endpoint.h"],
29-
external_deps = ["gtest"],
29+
external_deps = [
30+
"absl/log:log",
31+
"gtest",
32+
],
3033
deps = [
3134
"//:grpc",
3235
"//src/core:grpc_promise_endpoint",
@@ -37,7 +40,10 @@ grpc_cc_library(
3740
name = "transport_test",
3841
testonly = 1,
3942
hdrs = ["transport_test.h"],
40-
external_deps = ["gtest"],
43+
external_deps = [
44+
"absl/log:log",
45+
"gtest",
46+
],
4147
deps = [
4248
"//:iomgr_timer",
4349
"//src/core:memory_quota",

0 commit comments

Comments
 (0)