Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downloads: redundant x86_86 marker for Windows 64-bit conda-forge binary + wrong 32-bit version #271

Closed
vszakats opened this issue Jul 19, 2023 · 3 comments

Comments

@vszakats
Copy link
Member

vszakats commented Jul 19, 2023

Noticed two (was: three, the "i386" marker fixed by @bagder, thanks!) issues with the new conda-forge downloads:

  1. The x86_64 platform marker is redundant and messes up the order under Windows 64-bit. I think we should delete it as well.
    Screen Shot 2023-07-19 at 17 34 58

  2. The 32-bit curl binary distributed under conda-forge is actually version 7.60.0. They are no longer doing 32-bit builds. It means we should either delete that entry or fix version detection to detect the win-32 binary version instead.
    Screen Shot 2023-07-21 at 17 22 33
    Screen Shot 2023-07-19 at 17 29 08

conda-forge curl downloads: https://anaconda.org/conda-forge/curl
conda-forge curl build scripts: https://github.com/conda-forge/curl-feedstock/

Moved from: #196 (comment)

@vszakats vszakats changed the title downloads: redundant x86_86 marker for Windows 64-bit conda-forge binary + wrong version 32-bit binary downloads: redundant x86_86 marker for Windows 64-bit conda-forge binary + wrong 32-bit version Jul 19, 2023
@vszakats
Copy link
Member Author

vszakats commented Jul 26, 2023

@bagder Can you help fixing these? IMO we should just delete the 32-bit conda binary. It is old. Along with the x86_64 marker for conda 64-bit.

@dfandrich
Copy link
Collaborator

dfandrich commented Jul 26, 2023 via email

@vszakats
Copy link
Member Author

Thanks @dfandrich! Looking perfect now and in-sync with the https://curl.se/windows page.

I can imagine two solutions to improve this in the future:

  1. Merge "Windows 64-bit" and "Windows 32-bit" to a single box titled "Windows", and list "x86" vs "x64" vs "ARM64" (the Windowsy CPU terms) for all items.
  2. Split off ARM64 into a separate box titled "Windows ARM64" and rename "Windows 64-bit" → "Windows x64", "Windows 32-bit" → "Windows x86" (and use these for all items).

In Cygwin, we could change the title to "Windows Cygwin" and items to "Windows Cygwin x86_64", since the unixy CPU name is perferred there.

Screen Shot 2023-07-26 at 21 49 55

Screen Shot 2023-07-26 at 21 49 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants