utils_test.go

/*
Copyright 2021 The KServe Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package utils

import (
	"errors"
	"reflect"
	"strconv"
	"testing"

	"github.com/google/go-cmp/cmp"
	"github.com/onsi/gomega"
	"github.com/onsi/gomega/types"
	corev1 "k8s.io/api/core/v1"
	"k8s.io/apimachinery/pkg/api/resource"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

	"github.com/kserve/kserve/pkg/constants"
	"github.com/kserve/kserve/pkg/credentials/gcs"
)

func TestFilterUtil(t *testing.T) {
	scenarios := map[string]struct {
		input     map[string]string
		predicate func(string) bool
		expected  map[string]string
	}{
		"TruthyFilter": {
			input:     map[string]string{"key1": "val1", "key2": "val2"},
			predicate: func(key string) bool { return true },
			expected:  map[string]string{"key1": "val1", "key2": "val2"},
		},
		"FalsyFilter": {
			input:     map[string]string{"key1": "val1", "key2": "val2"},
			predicate: func(key string) bool { return false },
			expected:  map[string]string{},
		},
	}
	for name, scenario := range scenarios {
		result := Filter(scenario.input, scenario.predicate)

		if diff := cmp.Diff(scenario.expected, result); diff != "" {
			t.Errorf("Test %q unexpected result (-want +got): %v", name, diff)
		}
	}
}

func TestUnionUtil(t *testing.T) {
	scenarios := map[string]struct {
		input1   map[string]string
		input2   map[string]string
		expected map[string]string
	}{
		"UnionTwoMaps": {
			input1: map[string]string{
				"serving.kserve.io/service": "mnist",
				"label1":                    "value1",
			},
			input2: map[string]string{
				"service.knative.dev/service": "mnist",
				"label2":                      "value2",
			},
			expected: map[string]string{
				"serving.kserve.io/service": "mnist",
				"label1":                    "value1", "service.knative.dev/service": "mnist", "label2": "value2",
			},
		},
		"UnionTwoMapsOverwritten": {
			input1: map[string]string{
				"serving.kserve.io/service": "mnist",
				"label1":                    "value1", "label3": "value1",
			},
			input2: map[string]string{
				"service.knative.dev/service": "mnist",
				"label2":                      "value2", "label3": "value3",
			},
			expected: map[string]string{
				"serving.kserve.io/service": "mnist",
				"label1":                    "value1", "service.knative.dev/service": "mnist", "label2": "value2", "label3": "value3",
			},
		},
		"UnionWithEmptyMap": {
			input1: map[string]string{},
			input2: map[string]string{
				"service.knative.dev/service": "mnist",
				"label2":                      "value2",
			},
			expected: map[string]string{"service.knative.dev/service": "mnist", "label2": "value2"},
		},
		"UnionWithNilMap": {
			input1: nil,
			input2: map[string]string{
				"service.knative.dev/service": "mnist",
				"label2":                      "value2",
			},
			expected: map[string]string{"service.knative.dev/service": "mnist", "label2": "value2"},
		},
		"UnionNilMaps": {
			input1:   nil,
			input2:   nil,
			expected: map[string]string{},
		},
	}
	for name, scenario := range scenarios {
		result := Union(scenario.input1, scenario.input2)

		if diff := cmp.Diff(scenario.expected, result); diff != "" {
			t.Errorf("Test %q unexpected result (-want +got): %v", name, diff)
		}
	}
}

func TestContainsUtil(t *testing.T) {
	scenarios := map[string]struct {
		input1   []string
		input2   string
		expected bool
	}{
		"SliceContainsString": {
			input1:   []string{"hey", "hello"},
			input2:   "hey",
			expected: true,
		},
		"SliceDoesNotContainString": {
			input1:   []string{"hey", "hello"},
			input2:   "he",
			expected: false,
		},
		"SliceIsEmpty": {
			input1:   []string{},
			input2:   "hey",
			expected: false,
		},
	}
	for name, scenario := range scenarios {
		result := Includes(scenario.input1, scenario.input2)
		if diff := cmp.Diff(scenario.expected, result); diff != "" {
			t.Errorf("Test %q unexpected result (-want +got): %v", name, diff)
		}
	}
}

func TestAppendVolumeIfNotExists(t *testing.T) {
	scenarios := map[string]struct {
		volumes         []corev1.Volume
		volume          corev1.Volume
		expectedVolumes []corev1.Volume
	}{
		"DuplicateVolume": {
			volumes: []corev1.Volume{
				{
					Name: gcs.GCSCredentialVolumeName,
					VolumeSource: corev1.VolumeSource{
						Secret: &corev1.SecretVolumeSource{
							SecretName: "user-gcp-sa",
						},
					},
				},
				{
					Name: "blue",
					VolumeSource: corev1.VolumeSource{
						Secret: &corev1.SecretVolumeSource{
							SecretName: "user-gcp-sa",
						},
					},
				},
			},
			volume: corev1.Volume{
				Name: gcs.GCSCredentialVolumeName,
				VolumeSource: corev1.VolumeSource{
					Secret: &corev1.SecretVolumeSource{
						SecretName: "user-gcp-sa",
					},
				},
			},
			expectedVolumes: []corev1.Volume{
				{
					Name: gcs.GCSCredentialVolumeName,
					VolumeSource: corev1.VolumeSource{
						Secret: &corev1.SecretVolumeSource{
							SecretName: "user-gcp-sa",
						},
					},
				},
				{
					Name: "blue",
					VolumeSource: corev1.VolumeSource{
						Secret: &corev1.SecretVolumeSource{
							SecretName: "user-gcp-sa",
						},
					},
				},
			},
		},
		"NotDuplicateVolume": {
			volumes: []corev1.Volume{
				{
					Name: gcs.GCSCredentialVolumeName,
					VolumeSource: corev1.VolumeSource{
						Secret: &corev1.SecretVolumeSource{
							SecretName: "user-gcp-sa",
						},
					},
				},
				{
					Name: "blue",
					VolumeSource: corev1.VolumeSource{
						Secret: &corev1.SecretVolumeSource{
							SecretName: "user-gcp-sa",
						},
					},
				},
			},
			volume: corev1.Volume{
				Name: "green",
				VolumeSource: corev1.VolumeSource{
					Secret: &corev1.SecretVolumeSource{
						SecretName: "user-gcp-sa",
					},
				},
			},
			expectedVolumes: []corev1.Volume{
				{
					Name: gcs.GCSCredentialVolumeName,
					VolumeSource: corev1.VolumeSource{
						Secret: &corev1.SecretVolumeSource{
							SecretName: "user-gcp-sa",
						},
					},
				},
				{
					Name: "blue",
					VolumeSource: corev1.VolumeSource{
						Secret: &corev1.SecretVolumeSource{
							SecretName: "user-gcp-sa",
						},
					},
				},
				{
					Name: "green",
					VolumeSource: corev1.VolumeSource{
						Secret: &corev1.SecretVolumeSource{
							SecretName: "user-gcp-sa",
						},
					},
				},
			},
		},
	}

	for name, scenario := range scenarios {
		volumes := AppendVolumeIfNotExists(scenario.volumes, scenario.volume)

		if diff := cmp.Diff(scenario.expectedVolumes, volumes); diff != "" {
			t.Errorf("Test %q unexpected volume (-want +got): %v", name, diff)
		}
	}
}

func TestMergeEnvs(t *testing.T) {
	scenarios := map[string]struct {
		baseEnvs     []corev1.EnvVar
		overrideEnvs []corev1.EnvVar
		expectedEnvs []corev1.EnvVar
	}{
		"EmptyOverrides": {
			baseEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value1",
				},
			},
			overrideEnvs: []corev1.EnvVar{},
			expectedEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value1",
				},
			},
		},
		"EmptyBase": {
			baseEnvs: []corev1.EnvVar{},
			overrideEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value1",
				},
			},
			expectedEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value1",
				},
			},
		},
		"NoOverlap": {
			baseEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value1",
				},
			},
			overrideEnvs: []corev1.EnvVar{
				{
					Name:  "name2",
					Value: "value2",
				},
			},
			expectedEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value1",
				},
				{
					Name:  "name2",
					Value: "value2",
				},
			},
		},
		"SingleOverlap": {
			baseEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value1",
				},
			},
			overrideEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value2",
				},
			},
			expectedEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value2",
				},
			},
		},
		"MultiOverlap": {
			baseEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value1",
				},
				{
					Name:  "name2",
					Value: "value2",
				},
				{
					Name:  "name3",
					Value: "value3",
				},
			},
			overrideEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value3",
				},
				{
					Name:  "name3",
					Value: "value1",
				},
				{
					Name:  "name4",
					Value: "value4",
				},
			},
			expectedEnvs: []corev1.EnvVar{
				{
					Name:  "name1",
					Value: "value3",
				},
				{
					Name:  "name2",
					Value: "value2",
				},
				{
					Name:  "name3",
					Value: "value1",
				},
				{
					Name:  "name4",
					Value: "value4",
				},
			},
		},
	}

	for name, scenario := range scenarios {
		envs := MergeEnvs(scenario.baseEnvs, scenario.overrideEnvs)

		if diff := cmp.Diff(scenario.expectedEnvs, envs); diff != "" {
			t.Errorf("Test %q unexpected envs (-want +got): %v", name, diff)
		}
	}
}

func TestIncludesArg(t *testing.T) {
	g := gomega.NewGomegaWithT(t)
	args := []string{
		constants.ArgumentModelName,
	}
	scenarios := map[string]struct {
		arg      string
		expected bool
	}{
		"SliceContainsArg": {
			arg:      constants.ArgumentModelName,
			expected: true,
		},
		"SliceNotContainsArg": {
			arg:      "NoArg",
			expected: false,
		},
	}
	for name, scenario := range scenarios {
		t.Run(name, func(t *testing.T) {
			res := IncludesArg(args, scenario.arg)
			g.Expect(res).To(gomega.Equal(scenario.expected))
		})
	}
}

func TestIsGpuEnabled(t *testing.T) {
	g := gomega.NewGomegaWithT(t)
	scenarios := map[string]struct {
		resource corev1.ResourceRequirements
		expected bool
	}{
		"GpuEnabled": {
			resource: corev1.ResourceRequirements{
				Limits: corev1.ResourceList{
					"cpu": resource.Quantity{
						Format: "100",
					},
					constants.NvidiaGPUResourceType: resource.MustParse("1"),
				},
				Requests: corev1.ResourceList{
					"cpu": resource.Quantity{
						Format: "90",
					},
					constants.NvidiaGPUResourceType: resource.MustParse("1"),
				},
			},
			expected: true,
		},
		"GPUDisabled": {
			resource: corev1.ResourceRequirements{
				Limits: corev1.ResourceList{
					"cpu": resource.Quantity{
						Format: "100",
					},
				},
				Requests: corev1.ResourceList{
					"cpu": resource.Quantity{
						Format: "90",
					},
				},
			},
			expected: false,
		},
	}
	for name, scenario := range scenarios {
		t.Run(name, func(t *testing.T) {
			res := IsGPUEnabled(scenario.resource)
			g.Expect(res).To(gomega.Equal(scenario.expected))
		})
	}
}

func TestFirstNonNilError(t *testing.T) {
	g := gomega.NewGomegaWithT(t)
	scenarios := map[string]struct {
		errors  []error
		matcher types.GomegaMatcher
	}{
		"NoNonNilError": {
			errors: []error{
				nil,
				nil,
			},
			matcher: gomega.BeNil(),
		},
		"ContainsError": {
			errors: []error{
				nil,
				errors.New("First non nil error"),
				errors.New("Second non nil error"),
			},
			matcher: gomega.Equal(errors.New("First non nil error")),
		},
	}
	for name, scenario := range scenarios {
		t.Run(name, func(t *testing.T) {
			err := FirstNonNilError(scenario.errors)
			g.Expect(err).Should(scenario.matcher)
		})
	}
}

func TestRemoveString(t *testing.T) {
	g := gomega.NewGomegaWithT(t)
	testStrings := []string{
		"Model Tensorflow",
		"SKLearn Model",
		"Model",
		"ModelPytorch",
	}
	expected := []string{
		"Model Tensorflow",
		"SKLearn Model",
		"ModelPytorch",
	}
	res := RemoveString(testStrings, "Model")
	g.Expect(res).Should(gomega.Equal(expected))
}

func TestIsPrefixSupported(t *testing.T) {
	g := gomega.NewGomegaWithT(t)
	prefixes := []string{
		"S3://",
		"GCS://",
		"HTTP://",
		"HTTPS://",
	}
	scenarios := map[string]struct {
		input    string
		expected bool
	}{
		"SupportedPrefix": {
			input:    "GCS://test/model",
			expected: true,
		},
		"UnSupportedPreifx": {
			input:    "PVC://test/model",
			expected: false,
		},
	}
	for name, scenario := range scenarios {
		t.Run(name, func(t *testing.T) {
			res := IsPrefixSupported(scenario.input, prefixes)
			g.Expect(res).Should(gomega.Equal(scenario.expected))
		})
	}
}

func TestGetEnvVarValue(t *testing.T) {
	g := gomega.NewGomegaWithT(t)
	scenarios := map[string]struct {
		envList          []corev1.EnvVar
		targetEnvName    string
		expectedEnvValue string
		expectedExist    bool
	}{
		"EnvExist": {
			envList: []corev1.EnvVar{
				{Name: "test-name", Value: "test-value"},
			},
			targetEnvName:    "test-name",
			expectedEnvValue: "test-value",
			expectedExist:    true,
		},
		"EnvDoesNotExist": {
			envList: []corev1.EnvVar{
				{Name: "test-name", Value: "test-value"},
			},
			targetEnvName:    "wrong",
			expectedEnvValue: "",
			expectedExist:    false,
		},
	}

	for name, scenario := range scenarios {
		t.Run(name, func(t *testing.T) {
			res, exists := GetEnvVarValue(scenario.envList, scenario.targetEnvName)
			g.Expect(res).Should(gomega.Equal(scenario.expectedEnvValue))
			g.Expect(exists).Should(gomega.Equal(scenario.expectedExist))
		})
	}
}

func TestIsUnknownGpuResourceType(t *testing.T) {
	g := gomega.NewGomegaWithT(t)

	scenarios := map[string]struct {
		resources       corev1.ResourceRequirements
		annotations     map[string]string
		expectedUnknown bool
	}{
		"OnlyBasicResources": {
			resources: corev1.ResourceRequirements{
				Limits: corev1.ResourceList{
					corev1.ResourceCPU:    resource.MustParse("1"),
					corev1.ResourceMemory: resource.MustParse("1Gi"),
				},
				Requests: corev1.ResourceList{
					corev1.ResourceCPU:    resource.MustParse("1"),
					corev1.ResourceMemory: resource.MustParse("1Gi"),
				},
			},
			annotations:     map[string]string{},
			expectedUnknown: false,
		},
		"ValidGpuResource": {
			resources: corev1.ResourceRequirements{
				Limits: corev1.ResourceList{
					corev1.ResourceCPU:                    resource.MustParse("1"),
					corev1.ResourceMemory:                 resource.MustParse("1Gi"),
					corev1.ResourceName("nvidia.com/gpu"): resource.MustParse("1"),
				},
				Requests: corev1.ResourceList{
					corev1.ResourceCPU:                    resource.MustParse("1"),
					corev1.ResourceMemory:                 resource.MustParse("1Gi"),
					corev1.ResourceName("nvidia.com/gpu"): resource.MustParse("1"),
				},
			},
			annotations:     map[string]string{},
			expectedUnknown: false,
		},
		"UnknownGpuResource": {
			resources: corev1.ResourceRequirements{
				Limits: corev1.ResourceList{
					corev1.ResourceCPU:                     resource.MustParse("1"),
					corev1.ResourceMemory:                  resource.MustParse("1Gi"),
					corev1.ResourceName("unknown.com/gpu"): resource.MustParse("1"),
				},
				Requests: corev1.ResourceList{
					corev1.ResourceCPU:                     resource.MustParse("1"),
					corev1.ResourceMemory:                  resource.MustParse("1Gi"),
					corev1.ResourceName("unknown.com/gpu"): resource.MustParse("1"),
				},
			},
			annotations:     map[string]string{},
			expectedUnknown: true,
		},
		"UnknownGpuResourceWithAnnotation": {
			resources: corev1.ResourceRequirements{
				Limits: corev1.ResourceList{
					corev1.ResourceCPU:                       resource.MustParse("1"),
					corev1.ResourceMemory:                    resource.MustParse("1Gi"),
					corev1.ResourceName("unknown.com-1/gpu"): resource.MustParse("1"),
				},
				Requests: corev1.ResourceList{
					corev1.ResourceCPU:                       resource.MustParse("1"),
					corev1.ResourceMemory:                    resource.MustParse("1Gi"),
					corev1.ResourceName("unknown.com-1/gpu"): resource.MustParse("1"),
				},
			},
			annotations:     map[string]string{constants.CustomGPUResourceTypesAnnotationKey: `["unknown.com-1/gpu"]`},
			expectedUnknown: false,
		},
		"MixedResources": {
			resources: corev1.ResourceRequirements{
				Limits: corev1.ResourceList{
					corev1.ResourceCPU:                    resource.MustParse("1"),
					corev1.ResourceMemory:                 resource.MustParse("1Gi"),
					corev1.ResourceName("nvidia.com/gpu"): resource.MustParse("1"),
				},
				Requests: corev1.ResourceList{
					corev1.ResourceCPU:                     resource.MustParse("1"),
					corev1.ResourceMemory:                  resource.MustParse("1Gi"),
					corev1.ResourceName("unknown.com/gpu"): resource.MustParse("1"),
				},
			},
			annotations:     map[string]string{},
			expectedUnknown: true,
		},
		"MixedResourcesWithAnnotation": {
			resources: corev1.ResourceRequirements{
				Limits: corev1.ResourceList{
					corev1.ResourceCPU:                    resource.MustParse("1"),
					corev1.ResourceMemory:                 resource.MustParse("1Gi"),
					corev1.ResourceName("nvidia.com/gpu"): resource.MustParse("1"),
				},
				Requests: corev1.ResourceList{
					corev1.ResourceCPU:                       resource.MustParse("1"),
					corev1.ResourceMemory:                    resource.MustParse("1Gi"),
					corev1.ResourceName("unknown.com-2/gpu"): resource.MustParse("1"),
				},
			},
			annotations:     map[string]string{constants.CustomGPUResourceTypesAnnotationKey: `["unknown.com-2/gpu"]`},
			expectedUnknown: false,
		},
		"EmptyResources": {
			resources: corev1.ResourceRequirements{
				Limits:   corev1.ResourceList{},
				Requests: corev1.ResourceList{},
			},
			annotations:     map[string]string{},
			expectedUnknown: false,
		},
	}

	for name, scenario := range scenarios {
		t.Run(name, func(t *testing.T) {
			result, _ := IsUnknownGpuResourceType(scenario.resources, scenario.annotations)
			g.Expect(result).Should(gomega.Equal(scenario.expectedUnknown))
		})
	}
}

func TestIsValidCustomGPUArray(t *testing.T) {
	tests := []struct {
		input                       string
		expected                    bool
		expectedNewGPUResourceTypes []string
	}{
		{"[\"custom-gpu-1.com/gpu\"]", true, []string{"custom-gpu-1.com/gpu"}},
		{"[\"custom-gpu-1.com/gpu\",\"custom-gpu-2.com/gpu\"]", true, []string{"custom-gpu-1.com/gpu", "custom-gpu-2.com/gpu"}},
		{"[\"custom-gpu-1.com/gpu\",\"custom-gpu-2.com/gpu\",\"custom-gpu-3.com/gpu\"]", true, []string{"custom-gpu-1.com/gpu", "custom-gpu-2.com/gpu", "custom-gpu-3.com/gpu"}},
		{"[]", false, nil},
		{"[\"\"custom-gpu-1.com/gpu\"\", \"\"custom-gpu-2.com/gpu\"\", \"\"]", false, nil},
		{"[\"\"custom-gpu-1.com/gpu\"\", 42]", false, nil},
		{"[\"\"custom-gpu-1.com/gpu\"\", \"\"custom-gpu-2.com/gpu\"\",]", false, nil},
		{"[\"\"custom-gpu-1.com/gpu\"\", \"\"custom-gpu-2.com/gpu\"\", \"\"custom-gpu-3.com/gpu\"\"", false, nil},
		{"[custom-gpu-1.com/gpu, custom-gpu-2.com/gpu]", false, nil},
		{"[\"\"custom-gpu-1.com/gpu\"\", \"\"custom-gpu-2.com/gpu\"\" \"\"custom-gpu-3.com/gpu\"\"]", false, nil},
		{"[\"\"custom-gpu-1.com/gpu\"\", null]", false, nil},
		{"[\"\"custom-gpu-1.com/gpu\"\", true]", false, nil},
		{"[\"\"custom-gpu-1.com/gpu\"\", false]", false, nil},
		{"[\"\"custom-gpu-1.com/gpu\"\", \"\"custom-gpu-2.com/gpu\"\", 42]", false, nil},
		{"[\"\"custom-gpu-1.com/gpu\"\", \"\"custom-gpu-2.com/gpu\"\", \"\"custom-gpu-3.com/gpu\"\", \"\"]", false, nil},
	}

	for _, test := range tests {
		t.Run(test.input, func(t *testing.T) {
			newGPUResourceTypes, isValid := IsValidCustomGPUArray(test.input)
			if isValid != test.expected {
				t.Errorf("expected %v, got %v", test.expected, isValid)
			}
			if !reflect.DeepEqual(newGPUResourceTypes, test.expectedNewGPUResourceTypes) {
				t.Errorf("expected %v, got %v", test.expectedNewGPUResourceTypes, newGPUResourceTypes)
			}
		})
	}
}

func TestAppendEnvVarIfNotExists(t *testing.T) {
	scenarios := map[string]struct {
		initialEnvs  []corev1.EnvVar
		newEnvs      []corev1.EnvVar
		expectedEnvs []corev1.EnvVar
	}{
		"EnvVarAlreadyExists": {
			initialEnvs: []corev1.EnvVar{
				{Name: "ENV1", Value: "value1"},
				{Name: "ENV2", Value: "value2"},
			},
			newEnvs: []corev1.EnvVar{
				{Name: "ENV1", Value: "new_value1"},
			},
			expectedEnvs: []corev1.EnvVar{
				{Name: "ENV1", Value: "value1"},
				{Name: "ENV2", Value: "value2"},
			},
		},
		"EnvVarDoesNotExist": {
			initialEnvs: []corev1.EnvVar{
				{Name: "ENV1", Value: "value1"},
			},
			newEnvs: []corev1.EnvVar{
				{Name: "ENV2", Value: "value2"},
			},
			expectedEnvs: []corev1.EnvVar{
				{Name: "ENV1", Value: "value1"},
				{Name: "ENV2", Value: "value2"},
			},
		},
		"MultipleNewEnvVars": {
			initialEnvs: []corev1.EnvVar{
				{Name: "ENV1", Value: "value1"},
			},
			newEnvs: []corev1.EnvVar{
				{Name: "ENV2", Value: "value2"},
				{Name: "ENV3", Value: "value3"},
			},
			expectedEnvs: []corev1.EnvVar{
				{Name: "ENV1", Value: "value1"},
				{Name: "ENV2", Value: "value2"},
				{Name: "ENV3", Value: "value3"},
			},
		},
		"NoInitialEnvVars": {
			initialEnvs: []corev1.EnvVar{},
			newEnvs: []corev1.EnvVar{
				{Name: "ENV1", Value: "value1"},
			},
			expectedEnvs: []corev1.EnvVar{
				{Name: "ENV1", Value: "value1"},
			},
		},
	}

	for name, scenario := range scenarios {
		t.Run(name, func(t *testing.T) {
			result := AppendEnvVarIfNotExists(scenario.initialEnvs, scenario.newEnvs...)
			if diff := cmp.Diff(scenario.expectedEnvs, result); diff != "" {
				t.Errorf("Test %q unexpected result (-want +got): %v", name, diff)
			}
		})
	}
}

func TestAppendPortIfNotExists(t *testing.T) {
	scenarios := map[string]struct {
		initialPorts  []corev1.ContainerPort
		newPorts      []corev1.ContainerPort
		expectedPorts []corev1.ContainerPort
	}{
		"PortAlreadyExists": {
			initialPorts: []corev1.ContainerPort{
				{Name: "port1", ContainerPort: 8080},
				{Name: "port2", ContainerPort: 9090},
			},
			newPorts: []corev1.ContainerPort{
				{Name: "port1", ContainerPort: 8081},
			},
			expectedPorts: []corev1.ContainerPort{
				{Name: "port1", ContainerPort: 8080},
				{Name: "port2", ContainerPort: 9090},
			},
		},
		"PortDoesNotExist": {
			initialPorts: []corev1.ContainerPort{
				{Name: "port1", ContainerPort: 8080},
			},
			newPorts: []corev1.ContainerPort{
				{Name: "port2", ContainerPort: 9090},
			},
			expectedPorts: []corev1.ContainerPort{
				{Name: "port1", ContainerPort: 8080},
				{Name: "port2", ContainerPort: 9090},
			},
		},
		"MultipleNewPorts": {
			initialPorts: []corev1.ContainerPort{
				{Name: "port1", ContainerPort: 8080},
			},
			newPorts: []corev1.ContainerPort{
				{Name: "port2", ContainerPort: 9090},
				{Name: "port3", ContainerPort: 10090},
			},
			expectedPorts: []corev1.ContainerPort{
				{Name: "port1", ContainerPort: 8080},
				{Name: "port2", ContainerPort: 9090},
				{Name: "port3", ContainerPort: 10090},
			},
		},
		"NoInitialPorts": {
			initialPorts: []corev1.ContainerPort{},
			newPorts: []corev1.ContainerPort{
				{Name: "port1", ContainerPort: 8080},
			},
			expectedPorts: []corev1.ContainerPort{
				{Name: "port1", ContainerPort: 8080},
			},
		},
	}

	for name, scenario := range scenarios {
		t.Run(name, func(t *testing.T) {
			result := AppendPortIfNotExists(scenario.initialPorts, scenario.newPorts...)
			if diff := cmp.Diff(scenario.expectedPorts, result); diff != "" {
				t.Errorf("Test %q unexpected result (-want +got): %v", name, diff)
			}
		})
	}
}

func TestSetAvailableResourcesForApi(t *testing.T) {
	g := gomega.NewGomegaWithT(t)

	scenarios := map[string]struct {
		groupVersion string
		resources    *metav1.APIResourceList
	}{
		"SetResourcesInEmptyCache": {
			groupVersion: "v1",
			resources: &metav1.APIResourceList{
				GroupVersion: "v1",
				APIResources: []metav1.APIResource{
					{Name: "pods", Kind: "Pod"},
				},
			},
		},
		"SetResourcesInNonEmptyCache": {
			groupVersion: "v1",
			resources: &metav1.APIResourceList{
				GroupVersion: "v1",
				APIResources: []metav1.APIResource{
					{Name: "services", Kind: "Service"},
				},
			},
		},
	}

	for name, scenario := range scenarios {
		t.Run(name, func(t *testing.T) {
			// Reset the cache before each test
			gvResourcesCache = nil

			SetAvailableResourcesForApi(scenario.groupVersion, scenario.resources)

			g.Expect(gvResourcesCache).ToNot(gomega.BeNil())
			g.Expect(gvResourcesCache[scenario.groupVersion]).To(gomega.BeComparableTo(scenario.resources))
		})
	}
}

func TestStringToInt32(t *testing.T) {
	scenarios := map[string]struct {
		input    string
		expected int32
		err      error
	}{
		"ValidInt32": {
			input:    "123",
			expected: 123,
			err:      nil,
		},
		"ValidNegativeInt32": {
			input:    "-123",
			expected: -123,
			err:      nil,
		},
		"ExceedsInt32Limit": {
			input:    "2147483648", // int32 max is 2147483647
			expected: 0,
			err:      &strconv.NumError{Func: "ParseInt", Num: "2147483648", Err: strconv.ErrRange},
		},
		"InvalidNumber": {
			input:    "abc",
			expected: 0,
			err:      &strconv.NumError{Func: "ParseInt", Num: "abc", Err: strconv.ErrSyntax},
		},
	}

	for name, scenario := range scenarios {
		t.Run(name, func(t *testing.T) {
			result, err := StringToInt32(scenario.input)
			if result != scenario.expected {
				t.Errorf("Test %q unexpected result: got (%d), want (%d)", name, result, scenario.expected)
			}
			if err != nil && scenario.err != nil {
				if err.Error() != scenario.err.Error() {
					t.Errorf("Test %q unexpected error: got (%v), want (%v)", name, err, scenario.err)
				}
			} else if !errors.Is(err, scenario.err) {
				t.Errorf("got %v, want %v", err, scenario.err)
			}
		})
	}
}

func TestUpdateGPUResourceTypeListByAnnotation(t *testing.T) {
	g := gomega.NewGomegaWithT(t)

	combineGPU := func(customList []string) []string {
		combindedList := append([]string{}, constants.DefaultGPUResourceTypeList...)
		combindedList = append(combindedList, customList...)
		return combindedList
	}
	tests := []struct {
		name                 string
		isvcAnnotations      map[string]string
		expectedResourceList []string
		expectError          types.GomegaMatcher
	}{
		{
			name: "Valid GPU resources with unique types",
			isvcAnnotations: map[string]string{
				constants.CustomGPUResourceTypesAnnotationKey: "[\"custom-gpu-1.com/gpu\", \"custom-gpu-2.com/gpu\"]",
			},
			expectedResourceList: combineGPU([]string{"custom-gpu-1.com/gpu", "custom-gpu-2.com/gpu"}),
			expectError:          gomega.BeNil(),
		},
		{
			name: "Invalid GPU format (invalid JSON)",
			isvcAnnotations: map[string]string{
				constants.CustomGPUResourceTypesAnnotationKey: "[custom-gpu-1.com/gpu, custom-gpu-2.com/gpu", // Invalid JSON
			},
			expectedResourceList: nil,
			expectError:          gomega.Not(gomega.BeNil()),
		},
		{
			name: "Existing GPU resources in annotation",
			isvcAnnotations: map[string]string{
				constants.CustomGPUResourceTypesAnnotationKey: "[\"custom-gpu-1.com/gpu\"]",
			},
			expectedResourceList: combineGPU([]string{"custom-gpu-1.com/gpu"}), // Should not add anything
			expectError:          gomega.BeNil(),
		},
	}

	// Test each case
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			// Run the function to be tested
			updatedList, err := UpdateGPUResourceTypeListByAnnotation(tt.isvcAnnotations)

			g.Expect(updatedList).Should(gomega.Equal(tt.expectedResourceList))
			g.Expect(err).Should(tt.expectError)
		})
	}
}

func TestUpdateGlobalGPUResourceTypeList(t *testing.T) {
	g := gomega.NewWithT(t)
	originalDefaultGPUResourceTypeList := append([]string{}, constants.DefaultGPUResourceTypeList...)
	combineGPU := func(customList []string) []string {
		combindedList := append([]string{}, constants.DefaultGPUResourceTypeList...)
		combindedList = append(combindedList, customList...)
		return combindedList
	}

	tests := []struct {
		name                string
		newGPUResourceTypes []string
		expectedResult      []string
	}{
		{
			name:                "Add new GPU resource types",
			newGPUResourceTypes: []string{"custom-gpu-1.com/gpu", "custom-gpu-2.com/gpu"},
			expectedResult:      combineGPU([]string{"custom-gpu-1.com/gpu", "custom-gpu-2.com/gpu"}),
		},
		{
			name:                "Avoid duplicates",
			newGPUResourceTypes: []string{"custom-gpu-1.com/gpu", constants.DefaultGPUResourceTypeList[0]},
			expectedResult:      combineGPU([]string{"custom-gpu-1.com/gpu"}),
		},
		{
			name:                "Avoid duplicates - 2",
			newGPUResourceTypes: []string{"custom-gpu-1.com/gpu", "custom-gpu-1.com/gpu"},
			expectedResult:      combineGPU([]string{"custom-gpu-1.com/gpu"}),
		},
		{
			name:                "Empty new GPU resource types",
			newGPUResourceTypes: []string{},
			expectedResult:      combineGPU([]string{}),
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			// Rest global GPU resource type list for next test case
			constants.DefaultGPUResourceTypeList = originalDefaultGPUResourceTypeList

			// Reset the constants for each test to ensure isolation
			err := UpdateGlobalGPUResourceTypeList(tt.newGPUResourceTypes)
			g.Expect(err).ShouldNot(gomega.HaveOccurred())
			g.Expect(constants.DefaultGPUResourceTypeList).Should(gomega.Equal(tt.expectedResult))
		})
	}
}