Fixed fatal and several warnings + WPCS + refactors (#23)

* refactor: add image check + change non-existing standard img size in get_featured_image_from_rest_api

* fix: change undefined method count + add check if term exists in get_number_of_posts_in_term.php

* refactor: check page exists before getting ID in get_page_id_from_page_title.php

* chore: apply WPWC

* fix: change glue order in implode because of deprecation in get_random_post_suggestion_by_categories.php

* refactor: remove unneeded extra variable in get_random_post_suggestion_by_categories.php

* refactor: change query_posts to get_posts because former changes the main query in get_random_post_suggestion_by_categories.php

* refactor: check if there are categories before proceeding in get_random_post_suggestion_by_categories.php

* fix: change non-existing $categories_string for $tags_string in get_random_post_suggestion_by_tag.php

* refactor: remove unneeded extra variable in get_random_post_suggestion_by_tags.php

* refactor: change query_posts to get_posts because former changes the main query in get_random_post_suggestion_by_tags.php

* refactor: check if there are tags before proceeding in get_random_post_suggestion_by_tags.php

* fix: correct way to get tags in get_random_post_suggestion_by_tags.php

* fix: change glue order in implode because of deprecation in get_random_post_suggestion_by_tags.php

* refactor: no need to change array to string for tag ids in get_random_post_suggestion_by_tags.php

* chore: apply WPWC

Co-authored-by: Baris @ 1815 <[email protected]>

Author: omnisite

src/get_featured_image_from_rest_api.php

@@ -16,7 +16,10 @@ function register_rest_images() {
 
 function get_rest_featured_image( $object, $field_name, $request ) {
     if ( $object['featured_media'] ) {
-        $img = wp_get_attachment_image_src( $object['featured_media'], 'app-thumb' );
+        $img = wp_get_attachment_image_src( $object['featured_media'], 'thumbnail' ); // change 'thumbnail' to other image size if needed
+        if ( empty( $img ) ) {
+            return false;
+        }
         return $img[0];
     }
     return false;

src/get_number_of_posts_in_term.php

@@ -10,4 +10,6 @@
 //Show the number of posts of any term by any identifier (e.g. for the term category and the term with id 1)
 
 $term = get_term_by( 'id', 1, 'category' );
-$term->count();
+if ( ! empty( $term ) ) {
+    echo $term->count;
+}

src/get_page_id_from_page_title.php

@@ -1,4 +1,6 @@
 <?php
 // This will return an object of the page
-$page    = get_page_by_title( 'page-name' );
-$page_id = $page->ID;
+$page = get_page_by_title( 'page-name' );
+if ( ! empty( $page ) ) {
+    $page_id = $page->ID;
+}

src/get_random_post_suggestion_by_categories.php

@@ -1,18 +1,20 @@
 <?php
 //get categories of post
-$categories        = get_the_terms( get_the_ID(), 'category' );
+$categories = get_the_terms( get_the_ID(), 'category' );
 
-//extract category id's from term objects
-$cat_ids           = array_column( $categories, 'term_id' );
+if ( ! empty( $categories ) ) {
+    //extract category id's from term objects
+    $cat_ids    = array_column( $categories, 'term_id' );
 
-//concat id's to a string with ',' as seperator
-$categories_string = implode($cat_ids, ',');
+    //concat id's to a string with ',' as seperator
+    $cat_ids    = implode( ',', $cat_ids );
 
-//get five random posts that are in any category of the current post
-$posts = query_posts( [
-    'post_not_in'   => get_the_ID(),
-    'cat'           => $categories_string,
-    'order'         => 'ASC',
-    'orderby'       => 'rand',
-    'post_per_page' => 5
-] );
+    //get five random posts that are in any category of the current post
+    $posts = get_posts( [
+        'post_not_in'   => get_the_ID(),
+        'cat'           => $cat_ids,
+        'order'         => 'ASC',
+        'orderby'       => 'rand',
+        'post_per_page' => 5
+    ] );
+}

src/get_random_post_suggestion_by_tags.php

@@ -1,18 +1,17 @@
 <?php
 //get tags of post
-$tags        = get_the_terms( get_the_ID(), 'tag' );
+$tags = get_the_tags( get_the_ID() );
 
-//extract tag id's from term objects
-$tag_ids     = array_column( $tags, 'term_id' );
+if ( ! empty( $tags ) ) {
+    //extract tag id's from term objects
+    $tag_ids = array_column( $tags, 'term_id' );
 
-//concat id's to a string with ',' as seperator
-$tags_string = implode( $tag_ids, ',' );
-
-//get five random posts that are in any tag of the current post
-$posts = query_posts( [
-    'post_not_in'   => get_the_ID(),
-    'tag__in'       => $categories_string,
-    'order'         => 'ASC',
-    'orderby'       => 'rand',
-    'post_per_page' => 5
-] );
+    //get five random posts that are in any tag of the current post
+    $posts = get_posts( [
+        'post_not_in'   => get_the_ID(),
+        'tag__in'       => $tags_string,
+        'order'         => 'ASC',
+        'orderby'       => 'rand',
+        'post_per_page' => 5
+    ] );
+}

src/remove_inline_styling_from_tag_cloud.php

@@ -1,6 +1,6 @@
 <?php
 function remove_tagcloud_inline_styling( $input ) {
-    return preg_replace( '/ style=("|\')(.*?)("|\')/','',$input );
+    return preg_replace( '/ style=("|\')(.*?)("|\')/', '', $input );
 }
 
 add_filter( 'wp_generate_tag_cloud', 'remove_tagcloud_inline_styling', 10, 1 );