Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dapp create doesn't recognize the new dapp.sol.json file #244

Closed
gbalabasquer opened this issue Jul 9, 2019 · 6 comments
Closed

dapp create doesn't recognize the new dapp.sol.json file #244

gbalabasquer opened this issue Jul 9, 2019 · 6 comments

Comments

@gbalabasquer
Copy link
Contributor

We've missed to adapt this command.

@rainbreak
Copy link
Member

Should work if dapp build --extract is used, but yes this is broken otherwise.

@rainbreak
Copy link
Member

To get this from the json we need to index by the full filepath, e.g.

<out/dapp.sol.json jq '.contracts["src/math.sol:DSMath"].bin' -r

The caller could provide the fully qualified name with the filepath (useful in case of collisions), or they can provide just the contract name as before, and we select the first instance of it in the json.

@gbalabasquer
Copy link
Contributor Author

Right, it works with --extract, but I guess we want to bring the value directly from the dapp.sol.json so it works always.

I think that is the best solution, to have both options, full path to avoid collisions, and first instance if not specified.

@nanexcool
Copy link
Contributor

#351 fixes this :)

@asymmetric
Copy link
Contributor

@gbalabasquer let us know if this fixes your issue and then we can close this :)

@gbalabasquer
Copy link
Contributor Author

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants