Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seth estimate -B parameter is hex #387

Closed
ksvirsky opened this issue Jun 10, 2020 · 1 comment
Closed

seth estimate -B parameter is hex #387

ksvirsky opened this issue Jun 10, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ksvirsky
Copy link
Contributor

It is a little confusing having to pass block number as hex in seth estimate, but as dec in seth call:

seth estimate -B 0xabcdef $CONTRACT $METHOD
seth call -B 123456 $CONTRACT $METHOD

It would be great to add decimal block number support to seth estimate.
Seems like just adding the following line from seth-call to seth-estimate is enough:
seth-call#L26
[[ $ETH_BLOCK = [0-9]* ]] && ETH_BLOCK=$(seth --to-hex "$ETH_BLOCK")
@MrChico MrChico added enhancement New feature or request good first issue Good for newcomers labels Jun 15, 2020
@d-xo
Copy link
Contributor

d-xo commented Jun 16, 2020

@ksvirsky pull requests are very welcome 🙂

@ksvirsky ksvirsky mentioned this issue Jun 21, 2020
Merged
@MrChico MrChico closed this as completed Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@d-xo @MrChico @ksvirsky