Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max HTTP request size/read buffer size arguments - names have changed, docs not updated #1504

Open
WhitWaldo opened this issue Mar 14, 2025 · 3 comments
Labels
kind/bug Something isn't working

Comments

@WhitWaldo
Copy link

Expected Behavior

The JS SDK runs several E2E tests before PRs can be accepted. In a recent one, I've updated the E2E test to use the latest Dapr runtime (1.15.3) and CLI (1.15.0).

Since then, one of the E2E tests is failing where it specifies the --dapr-http-max-request-size flag with an argument value of 10.

Since this argument is listed in the documentation, I would expect it'd be a legal flag.

This appears to be a regression, as I've successfully had two PRs complete E2E testing when this was previously using Dapr CLI version 1.14.0 and Dapr runtime 1.41.1 prior to this PR.

Actual Behavior

That E2E test fails before it even starts with the following ending in an error:

@dapr/[email protected] test:e2e:http:server
npm run prebuild && TEST_SECRET_1=secret_val_1 TEST_SECRET_2=secret_val_2 dapr run --app-id test-suite --app-protocol http --app-port 50001 --dapr-http-port 50000 --dapr-http-max-request-size 10 --components-path ./test/components -- jest --runInBand --detectOpenHandles --testMatch [ '**/test/e2e/http/(server).test.ts' ]

@dapr/[email protected] prebuild
./scripts/prebuild.sh

Error: unknown flag: --dapr-http-max-request-size
Usage:
unknown flag: --dapr-http-max-request-size
dapr run [flags]

Steps to Reproduce the Problem

Re-run the failed job.

Release Note

RELEASE NOTE: FIX Dapr CLI allows use of --dapr-http-max-request-size flag fixing regression

@WhitWaldo WhitWaldo added the kind/bug Something isn't working label Mar 14, 2025
@WhitWaldo
Copy link
Author

Found it - apparently not an unintentional regression, but the docs are out of date following this recent change.

This page says that --max-body-size isn't supported on the CLI, but the note for --dapr-http-max-request-size says --max-body-size should be used.

And this page doesn't mention --max-body-size at all.

@WhitWaldo
Copy link
Author

WhitWaldo commented Mar 16, 2025

This page also needs an update to reflect the new argument name of --dapr-http-read-buffer-size to --read-buffer-size

@WhitWaldo WhitWaldo changed the title Max HTTP request size argument not found Max HTTP request size/read buffer size arguments - names have changed, docs not updated Mar 17, 2025
@WhitWaldo
Copy link
Author

This page also needs the update to reflect the change to -dapr-http-read-buffer-size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant