Remove MatchingLinkResult.warn; unused (#3090)

Author: srawlins

lib/src/markdown_processor.dart

@@ -246,14 +246,12 @@ md.Node _makeLinkNode(String codeRef, Warnable warnable) {
     // else this would be linkedElement.linkedName, but link bodies are slightly
     // different for doc references, so fall out.
   } else {
-    if (result.warn) {
-      // Avoid claiming documentation is inherited when it comes from the
-      // current element.
-      warnable.warn(PackageWarning.unresolvedDocReference,
-          message: codeRef,
-          referredFrom:
-              warnable.documentationIsLocal ? [] : warnable.documentationFrom);
-    }
+    // Avoid claiming documentation is inherited when it comes from the
+    // current element.
+    warnable.warn(PackageWarning.unresolvedDocReference,
+        message: codeRef,
+        referredFrom:
+            warnable.documentationIsLocal ? [] : warnable.documentationFrom);
   }
 
   return md.Element.text('code', textContent);

lib/src/matching_link_result.dart

@@ -7,22 +7,20 @@ import 'package:dartdoc/src/model/model.dart';
 
 class MatchingLinkResult {
   final CommentReferable? commentReferable;
-  final bool warn;
 
-  MatchingLinkResult(this.commentReferable, {this.warn = true});
+  MatchingLinkResult(this.commentReferable);
 
   @override
-  bool operator ==(Object other) {
-    return other is MatchingLinkResult &&
-        commentReferable == other.commentReferable &&
-        warn == other.warn;
-  }
+  bool operator ==(Object other) =>
+      other is MatchingLinkResult && commentReferable == other.commentReferable;
 
   @override
-  int get hashCode => Object.hash(commentReferable, warn);
+  int get hashCode => commentReferable.hashCode;
 
   @override
   String toString() {
-    return 'element: [${commentReferable is Constructor ? 'new ' : ''}${commentReferable?.fullyQualifiedName}] warn: $warn';
+    // TODO(srawlins): Scrap the 'new' keyword?
+    final newKeyword = commentReferable is Constructor ? 'new ' : '';
+    return 'element: [$newKeyword${commentReferable?.fullyQualifiedName}]';
   }
 }

test/src/utils.dart

@@ -309,7 +309,7 @@ MatchingLinkResult definingLinkResult(MatchingLinkResult originalResult) {
 
   if (definingReferable != null &&
       definingReferable != originalResult.commentReferable) {
-    return MatchingLinkResult(definingReferable, warn: originalResult.warn);
+    return MatchingLinkResult(definingReferable);
   }
   return originalResult;
 }