Skip to content

Commit c90538b

Browse files
authored
Merge pull request amplitude#233 from amplitude/add_device_info
Added devices info for all cases
2 parents dc05a8e + a08df8f commit c90538b

File tree

3 files changed

+5
-18
lines changed

3 files changed

+5
-18
lines changed

.gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,6 @@ amplitude.nocompat.js
1313
amplitude.nocompat.min.js
1414
amplitude-snippet.min.js
1515
amplitude.native.js
16+
amplitude-segment-snippet.min.js
1617
.watchmanconfig
18+
package-lock.json

amplitude-segment-snippet.min.js

-16
This file was deleted.

src/amplitude-client.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -1142,8 +1142,9 @@ AmplitudeClient.prototype._logEvent = function _logEvent(eventType, eventPropert
11421142

11431143
let osName = this._ua.browser.name;
11441144
let osVersion = this._ua.browser.major;
1145-
let deviceModel = this._ua.os.name;
1146-
let deviceManufacturer;
1145+
let deviceModel = this._ua.device.model;
1146+
let deviceManufacturer = this._ua.device.vendor;
1147+
11471148
let versionName;
11481149
let carrier;
11491150
if (BUILD_COMPAT_REACT_NATIVE) {

0 commit comments

Comments
 (0)