fixes #3

shawnrc · shawnrc · commit cbbe5ff20140 · 2015-12-23T22:24:43.000-05:00
diff --git a/src/Exception/Evaluation.php b/src/Exception/Evaluation.php
@@ -44,7 +44,8 @@ public function __construct($message = '', $code = 0)
 
     private static function isValidCode($code)
     {
-        return is_int($code) && (($code < -32768) || (-32000 < $code));
+        // as defined by the JSON-RPC 2.0 spec, see http://www.jsonrpc.org/specification#error_object
+        return is_int($code) && (-32768 <= $code && $code <= -32000);
     }
 
     private static function isValidMessage($message)

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,8 @@ public function __construct($message = '', $code = 0)`
`44`	`44`
`45`	`45`	`private static function isValidCode($code)`
`46`	`46`	`{`
`47`		`- return is_int($code) && (($code < -32768) \|\| (-32000 < $code));`
	`47`	`+ // as defined by the JSON-RPC 2.0 spec, see http://www.jsonrpc.org/specification#error_object`
	`48`	`+ return is_int($code) && (-32768 <= $code && $code <= -32000);`
`48`	`49`	`}`
`49`	`50`
`50`	`51`	`private static function isValidMessage($message)`