Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For def _prob_in_top_k #31

Open
Brankozz opened this issue Jun 20, 2024 · 1 comment
Open

For def _prob_in_top_k #31

Brankozz opened this issue Jun 20, 2024 · 1 comment

Comments

@Brankozz
Copy link

Hey, sorry for bothering! I am just confused that you wrote the function as:
prob_if_in = normal.cdf((clean_values - threshold_if_in)/noise_stddev)
prob_if_out = normal.cdf((clean_values - threshold_if_out)/noise_stddev)

In my perspective, in the origin paper, regardless of threshold_if_in or threshold_if_out, it should be the initial logits(after adding the noise) before the softmax(initial logits). After I run the code, I find out the inputted threshold_if_in/out are actually from the softmax(initial logits).

Also in this commond "is_in = torch.gt(noisy_values, threshold_if_in)" the noisy_values are the initial logits, the threshold_if_in is the output of softmax(initial logits)

@tulilin
Copy link

tulilin commented Dec 4, 2024

@davidmrau I also found this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants