Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove compiled dependencies #2

Closed
mikeal opened this issue Apr 21, 2013 · 2 comments
Closed

remove compiled dependencies #2

mikeal opened this issue Apr 21, 2013 · 2 comments

Comments

@mikeal
Copy link

mikeal commented Apr 21, 2013

in the latest release you took typewise which depends on buffertools which is a compiled dependency. this limits the available deployments quite a bit.

@deanlandolt
Copy link
Owner

Yeah, it's an optionalDep, like everything else but es6-shim (and I've got a plan to make that optional too). There's a native Buffer compare function in buffertools that ought to be way faster than the js version, but it's not even working for me anyway, and it's definitely not necessary for your use cases in bytewise. I'll drop the dep -- hell, I think I can drop the dep to typewise entirely.

FYI the typewise stuff is just an implementation of the comparison algorithm as a js sort. But I'll demote i to a testDep of bytewise. I'd love to go all substack on this and move all of the deps out of typewise too, but I'm still thinking through the best way to package this up.

tldr; I'll dump the deps, but if you have any ideas about how to express the relationship between the version of the ordering used by bytewise and implemented in typewise I'd love to know. I guess peerDeps would work for this.

@deanlandolt
Copy link
Owner

I just released v0.4.0 w/o the typewise dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants