[#V1] Standardizes delete!, destroy!, & remove methods

Standardizes method naming across Redis type implementations to improve clarity and consistency

* Replaces various delete/remove methods with a unified `remove` method
* Clarifies the distinction between `delete!` and `destroy!` methods
* Enhances documentation for object lifecycle management methods

Author: delano

lib/familia/horreum/class_methods.rb

@@ -399,8 +399,10 @@ def exists?(identifier, suffix = nil)
       # @param suffix [Symbol, nil] The suffix to use in the Redis key (default: class suffix).
       # @return [Boolean] true if the object was successfully destroyed, false otherwise.
       #
-      # This method constructs the full Redis key using the provided identifier and suffix,
-      # then removes the corresponding key from Redis.
+      # This method is part of Familia's high-level object lifecycle management. While `delete!`
+      # operates directly on Redis keys, `destroy!` operates at the object level and is used for
+      # ORM-style operations. Use `destroy!` when removing complete objects from the system, and
+      # `delete!` when working directly with Redis keys.
       #
       # @example
       #   User.destroy!(123)  # Removes user:123:object from Redis

lib/familia/horreum/commands.rb

@@ -58,12 +58,11 @@ def realttl
         redis.ttl rediskey
       end
 
-      # Deletes a field from the hash stored at the Redis key.
+      # Removes a field from the hash stored at the Redis key.
       #
-      # @param field [String] The field to delete from the hash.
+      # @param field [String] The field to remove from the hash.
       # @return [Integer] The number of fields that were removed from the hash (0 or 1).
-      # @note This method is destructive, as indicated by the bang (!).
-      def hdel!(field)
+      def remove_field(field)
         Familia.trace :HDEL, redis, field, caller(1..1) if Familia.debug?
         redis.hdel rediskey, field
       end
@@ -162,12 +161,13 @@ def key?(field)
       end
       alias has_key? key?
 
+      # Deletes the entire Redis key
+      # @return [Boolean] true if the key was deleted, false otherwise
       def delete!
         Familia.trace :DELETE!, redis, redisuri, caller(1..1) if Familia.debug?
         ret = redis.del rediskey
         ret.positive?
       end
-      protected :delete!
 
     end
 

lib/familia/horreum/serialization.rb

@@ -253,6 +253,11 @@ def commit_fields update_expiration: true
       #   rocky.destroy!
       #   # => *poof* Rocky is no more. A moment of silence, please.
       #
+      # This method is part of Familia's high-level object lifecycle management. While `delete!`
+      # operates directly on Redis keys, `destroy!` operates at the object level and is used for
+      # ORM-style operations. Use `destroy!` when removing complete objects from the system, and
+      # `delete!` when working directly with Redis keys.
+      #
       # @note If debugging is enabled, this method will leave a trace of its
       #   destructive path, like breadcrumbs for future data archaeologists.
       #

lib/familia/redistype/commands.rb

@@ -22,11 +22,11 @@ def type
       redis.type rediskey
     end
 
+    # Deletes the entire Redis key
+    # @return [Boolean] true if the key was deleted, false otherwise
     def delete!
       redis.del rediskey
     end
-    alias clear delete!
-    alias del delete!
 
     def exists?
       redis.exists(rediskey) && !size.zero?

lib/familia/redistype/types/hashkey.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Familia
   class HashKey < RedisType
     def size
@@ -49,14 +47,13 @@ def keys
     end
 
     def values
-      elements = redis.hvals(rediskey)
-      multi_from_redis(*elements)
+      redis.hvals(rediskey).map { |v| load v }
     end
 
     def hgetall
-      # TODO: Use from_redis. Also alias `all` is confusing with
-      # Onetime::Customer.all which returns all customers.
-      redis.hgetall rediskey
+      redis.hgetall(rediskey).each_with_object({}) do |(k,v), ret|
+        ret[k] = from_redis v
+      end
     end
     alias all hgetall
 
@@ -67,12 +64,12 @@ def key?(field)
     alias include? key?
     alias member? key?
 
-    def delete(field)
+    # Removes a field from the hash
+    # @param field [String] The field to remove
+    # @return [Integer] The number of fields that were removed (0 or 1)
+    def remove(field)
       redis.hdel rediskey, field
     end
-    alias remove delete
-    alias rem delete
-    alias del delete
 
     def increment(field, by = 1)
       redis.hincrby(rediskey, field, by).to_i

lib/familia/redistype/types/list.rb

@@ -57,12 +57,13 @@ def [](idx, count = nil)
     end
     alias slice []
 
-    def delete(v, count = 0)
-      redis.lrem rediskey, count, to_redis(v)
+    # Removes elements equal to value from the list
+    # @param value The value to remove
+    # @param count [Integer] Number of elements to remove (0 means all)
+    # @return [Integer] The number of removed elements
+    def remove(value, count = 0)
+      redis.lrem rediskey, count, to_redis(value)
     end
-    alias remove delete
-    alias rem delete
-    alias del delete
 
     def range(sidx = 0, eidx = -1)
       elements = rangeraw sidx, eidx

lib/familia/redistype/types/sorted_set.rb

@@ -201,18 +201,18 @@ def decrement(val, by = 1)
     alias decr decrement
     alias decrby decrement
 
-    def delete(val)
-      Familia.trace :DELETE, redis, "#{val}<#{val.class}>", caller(1..1) if Familia.debug?
+    # Removes a member from the sorted set
+    # @param value The value to remove from the sorted set
+    # @return [Integer] The number of members that were removed (0 or 1)
+    def remove(value)
+      Familia.trace :DELETE, redis, "#{value}<#{value.class}>", caller(1..1) if Familia.debug?
       # We use `strict_values: false` here to allow for the deletion of values
       # that are in the sorted set. If it's a horreum object, the value is
       # the identifier and not a serialized version of the object. So either
       # the value exists in the sorted set or it doesn't -- we don't need to
       # raise an error if it's not found.
-      redis.zrem rediskey, to_redis(val, strict_values: false)
+      redis.zrem rediskey, to_redis(value, strict_values: false)
     end
-    alias remove delete
-    alias rem delete
-    alias del delete
 
     def at(idx)
       range(idx, idx).first

lib/familia/redistype/types/unsorted_set.rb

@@ -70,12 +70,12 @@ def member?(val)
     end
     alias include? member?
 
-    def delete(val)
-      redis.srem rediskey, to_redis(val)
+    # Removes a member from the set
+    # @param value The value to remove from the set
+    # @return [Integer] The number of members that were removed (0 or 1)
+    def remove(value)
+      redis.srem rediskey, to_redis(value)
     end
-    alias remove delete
-    alias rem delete
-    alias del delete
 
     def intersection *setkeys
       # TODO