Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][REST Client] Protocol version and wrap delta action server side changes have not been applied to REST client #4004

Open
2 of 8 tasks
sameerawi opened this issue Dec 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@sameerawi
Copy link

sameerawi commented Dec 27, 2024

Bug

Delta rest client

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (REST Client)

DeltaSharingProfile and Protocol version has not been updated to version 3 which impacts to rest client when connecting to a server that has tables with corresponding versions.

Server side change (Wrap delta action in the response action when responseFormat=delta) addressed in PR has not been updated in rest client side

Steps to reproduce

  1. Connect to a deltashare server with Protocol version 3 tables (Ideally tables with deletion vectors)
  2. Call query_table_metadata function on the DataSharingRestClient
client = DataSharingRestClient(DeltaSharingProfile.from_json(json.dumps(profile)))
client.set_delta_format_header()
table_metadata = client.query_table_metadata(Table.from_json(table_json))

print(table_metadata.metadata.schema_string)

Observed results

An error occurred: 'minReaderVersion'

Expected results

table_metadata variable should populated without any error

Further details

Environment information

  • Delta Lake version: 1.2.0

Willingness to contribute

The Delta Lake Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the Delta Lake code base?

  • Yes. I can contribute a fix for this bug independently.
  • Yes. I would be willing to contribute a fix for this bug with guidance from the Delta Lake community.
  • No. I cannot contribute a bug fix at this time.
@sameerawi sameerawi added the bug Something isn't working label Dec 27, 2024
@sameerawi sameerawi changed the title [BUG][REST Client] Protocol version and wrap delta action server side changes have not been applied to reset client [BUG][REST Client] Protocol version and wrap delta action server side changes have not been applied to REST client Dec 27, 2024
@sameerawi
Copy link
Author

PR has been raised to address this issue delta-io/delta-sharing#629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant