Use CMSApp.get_urls instead of deprecated attr urls

Author: jrief

example/myshop/cms_apps.py

@@ -11,28 +11,36 @@
 
 class ProductsListApp(CMSApp):
     name = _("Products List")
-    if settings.SHOP_TUTORIAL == 'polymorphic':
-        urls = ['myshop.urls.polymorphic_products']
-    elif settings.SHOP_TUTORIAL == 'i18n_commodity':
-        urls = ['myshop.urls.i18n_products']
-    else:
-        urls = ['myshop.urls.simple_products']
 
+    def get_urls(self, page=None, language=None, **kwargs):
+        if settings.SHOP_TUTORIAL == 'polymorphic':
+            return ['myshop.urls.polymorphic_products']
+        elif settings.SHOP_TUTORIAL == 'i18n_commodity':
+            return ['myshop.urls.i18n_products']
+        else:
 apphook_pool.register(ProductsListApp)
+            return ['myshop.urls.simple_products']
+
 
 
 class ProductSearchApp(CMSApp):
     name = _("Search")
-    urls = ['myshop.urls.search']
+
+    def get_urls(self, page=None, language=None, **kwargs):
+        return ['myshop.urls.search']
 
 apphook_pool.register(ProductSearchApp)
 
 
 class OrderApp(CMSApp):
     name = _("View Orders")
-    urls = ['shop.urls.order']
     cache_placeholders = False
 
+    def get_urls(self, page=None, language=None, **kwargs):
+        if page and page.reverse_id == 'shop-order-last':
+            return ['shop.urls.order_last']
+        return ['shop.urls.order']
+
 apphook_pool.register(OrderApp)
 
 

shop/urls/order_last.py

@@ -0,0 +1,9 @@
+# -*- coding: utf-8 -*-
+from __future__ import unicode_literals
+
+from django.conf.urls import url
+from shop.views.order import OrderView
+
+urlpatterns = [
+    url(r'^$', OrderView.as_view(many=False, is_last=True)),
+]

shop/views/order.py

@@ -24,6 +24,7 @@ class OrderView(mixins.ListModelMixin, mixins.RetrieveModelMixin, mixins.UpdateM
     detail_serializer_class = OrderDetailSerializer
     lookup_field = lookup_url_kwarg = 'slug'
     many = True
+    is_last = False
 
     def get_queryset(self):
         return OrderModel.objects.filter_from_request(self.request)
@@ -36,9 +37,9 @@ def get_serializer_class(self):
     def get_renderer_context(self):
         renderer_context = super(OrderView, self).get_renderer_context()
         if self.request.accepted_renderer.format == 'html':
-            renderer_context['many'] = self.many
-            if self.many is False:
-                # add an extra ance to the breadcrumb
+            renderer_context.update(many=self.many, is_last=self.is_last)
+            if self.many is False and self.is_last is False:
+                # add an extra ance to the breadcrumb to show the order number
                 try:
                     renderer_context['extra_ance'] = self.get_object().get_number()
                 except (AttributeError, PermissionDenied):
@@ -63,15 +64,11 @@ def allowed_methods(self):
 
     @never_cache
     def get(self, request, *args, **kwargs):
-        if self.is_last():
-            self.many = False
         if self.many:
             return self.list(request, *args, **kwargs)
         return self.retrieve(request, *args, **kwargs)
 
     def post(self, request, *args, **kwargs):
-        if self.is_last():
-            self.many = False
         if self.many:
             return self.list(request, *args, **kwargs)
         self.update(request, *args, **kwargs)
@@ -88,10 +85,3 @@ def retrieve(self, request, *args, **kwargs):
             return super(OrderView, self).retrieve(request, *args, **kwargs)
         except OrderModel.DoesNotExist:
             raise NotFound("No order has been found for the current user.")
-
-    def is_last(self):
-        """
-        Return true, if the last order shall be rendered.
-        Useful to render a Thank-You view immediately after a purchase.
-        """
-        return self.request.current_page.reverse_id == 'shop-order-last'