Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: contributors page #323

Open
arashsheyda opened this issue Apr 6, 2024 · 10 comments
Open

feat: contributors page #323

arashsheyda opened this issue Apr 6, 2024 · 10 comments
Assignees
Labels
PR wlecome Looking for people to contribute!

Comments

@arashsheyda
Copy link
Collaborator

it would be nice to have the contributors showen in website. we can have a seperate page to show all the contributors and a section in the homepage, something like this maybe:

note: we can fetch the contributors using github api.

Screenshot 2024-04-06 at 11 01 51 AM
@arashsheyda arashsheyda added the PR wlecome Looking for people to contribute! label Apr 7, 2024
@riyaahsp
Copy link

riyaahsp commented May 3, 2024

Hi, I would love to work on the contributors page.

@ajyong
Copy link
Member

ajyong commented Jun 7, 2024

@riyaahsp did you message me on Meetup? I can't reply on Meetup (due to privacy settings? It's confusing) but I am assuming this is you; if so, you can thank @arashsheyda for assigning you, which means it's less likely someone else will work on this. (That said, given how open-source works, it's a balance of quality and who contributes first.)

@dgmouris
Copy link
Collaborator

Hey @MandyMeindersma,

I spoke to @riyaahsp a few weeks ago about taking this, and she's okay with it. I'm going to do this with students and I'm going to open it back up.

It would be awesome to show maintainers on our website here.

@johnjovero98
Copy link
Contributor

johnjovero98 commented Nov 20, 2024

I have a proposal of what we can do for the landing page 👀

Wireframe:
contributors-widget

Widget Functionality:

  • the mini icons will redirect users to the contributor's GitHub profile or web portfolio, like in the DES repo page. (Though not 100% if collaborator links are included in the API response).

  • The "learn more" button will route to the contributors page that @arashsheyda proposed above.

I took inspiration and stole the mini icons from webpacks site (https://webpack.js.org/) 🤭

(P.S. Copywriting is not my passion, so feel free to revise and expand on the verbiage.)

@arashsheyda
Copy link
Collaborator Author

@johnjovero98 I love it. great work!
(maybe use primary or secondary colour for the borders around the image)

@dgmouris
Copy link
Collaborator

@johnjovero98 I love it too! great work.

For the contributors' page, should we discuss getting people to contribute to the site and include a link to this repo, or just the contributors themselves.

What do you think folks?

That might be a discussion later on but I think this is awesome @johnjovero98

@arashsheyda
Copy link
Collaborator Author

@dgmouris I was thinking for contributors page to show all the contributors (because the old design was showing the first 19 contributors at first) and then have a page about contribution guide where we explain somethings briefly (e.g. how to open a PR, how to set a title, commit message, (I really like Conventional Commits 😄) DES folder structure, tech stack and so on)

what do you all think?

@arashsheyda
Copy link
Collaborator Author

arashsheyda commented Dec 13, 2024

@dgmouris also one other thing I noticed is that we're using a bot to generate the contributors list in the repository's README. however, sometimes we can forget to call the bot, which results in some contributors being left out, would it be a good idea to embed the contributors list directly from the website into the README? or just add a link to the website and remove the contributors list from readme

@MandyMeindersma
Copy link
Contributor

I think we should just kill allcontributors 😬

The contributors are listed in the side by the readme anyways. I hate having to do the extra PR

@arashsheyda
Copy link
Collaborator Author

@MandyMeindersma I agree 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR wlecome Looking for people to contribute!
Projects
None yet
Development

No branches or pull requests

6 participants