Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming-generated guards for backward-propagation prefetching look fishy, but appear to work #2056

Open
FabioLuporini opened this issue Jan 30, 2023 · 0 comments
Open

Streaming-generated guards for backward-propagation prefetching look fishy, but appear to work #2056

FabioLuporini opened this issue Jan 30, 2023 · 0 comments
Assignees
@FabioLuporini @mloubout

Comments

@FabioLuporini
Copy link
Contributor

Complete discussion here: https://devitocodes.slack.com/archives/C7JMLMSG0/p1673960926948329

No MFE available right now

The issue discussion started here: https://github.com/devitocodes/devito/pull/2042/files#r1064672824

The latest suggestion from @mloubout was:

`p1-1 - (p1-1 + p0*factor)%factor`  this should always work. Basically always compute the modulo as the left part making sure it's positive by shifting it. This a bit brute force but a trivial shift multiple of factor

However, I tried it, and there were failures in PRO.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FabioLuporini FabioLuporini

@mloubout mloubout

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FabioLuporini @mloubout