Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparseFunctions + MPI + coordinates #928

Open
FabioLuporini opened this issue Sep 7, 2019 · 2 comments
Open

SparseFunctions + MPI + coordinates #928

FabioLuporini opened this issue Sep 7, 2019 · 2 comments
Assignees
Labels

Comments

@FabioLuporini
Copy link
Contributor

Assume rank0, out of 4 MPI ranks, has 8 items

a b c d e f g h

Now assume that, upon Operator application, the sparse points get distributed via _dist_scatter to the 4 ranks and the result is

a c  --- b d g --- e f --- h

Now, upon returning from Operator application, via _dist_gather, the sparse points get stored
either as

a c b d g e f h

OR

a b e h c d f g

(to be double checked)

So the layout is different than it was upon data allocation/initialization.

Instead of making sure the layout is deterministically the same, currently the coordinates are rather reshuffled the same way the sparse points are, so that the mapping position -> value is correct

This is horrible. Possible approaches to improve this:

  • Fix the bug such that upon gather, the layout is as expected
  • Make SparseFunctions unordered collections (difficult because we do wanna use Data, I imagine...)
@mloubout
Copy link
Contributor

Isn't this fixed?

@FabioLuporini
Copy link
Contributor Author

I think so, but I haven't touched that code in ages, so... 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants