Skip to content

Commit f031b3c

Browse files
committed
Cleanup.
1 parent bc458d9 commit f031b3c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

common.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
redis_sock->pipeline_current = tmp; \
6161
if(NULL == redis_sock->pipeline_head) { \
6262
redis_sock->pipeline_head = redis_sock->pipeline_current;\
63-
/* head_request = current_request;*/ \
6463
}
6564

6665
#define SOCKET_WRITE_COMMAND(redis_sock, cmd, cmd_len) if(redis_sock_write(redis_sock, cmd, cmd_len) < 0) { \
@@ -76,7 +75,6 @@
7675
if(current) current->next = f1; \
7776
redis_sock->current = f1; \
7877
if(NULL == redis_sock->head) { \
79-
/* head = current;*/ \
8078
redis_sock->head = redis_sock->current;\
8179
}\
8280
}

redis.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -784,7 +784,7 @@ PHP_METHOD(Redis, getMultiple)
784784
HashPosition pointer;
785785
RedisSock *redis_sock;
786786
char *cmd = "", *old_cmd = NULL;
787-
int cmd_len, array_count;
787+
int cmd_len = 0, array_count, elements = 1;
788788

789789
if (zend_parse_method_parameters(ZEND_NUM_ARGS() TSRMLS_CC, getThis(), "Oa",
790790
&object, redis_ce, &array) == FAILURE) {
@@ -812,16 +812,18 @@ PHP_METHOD(Redis, getMultiple)
812812
if(*cmd) {
813813
old_cmd = cmd;
814814
}
815-
cmd_len = spprintf(&cmd, 0, "%s %s", cmd, Z_STRVAL_PP(data));
815+
cmd_len = redis_cmd_format(&cmd, "%s$%d" _NL "%s" _NL
816+
, cmd, cmd_len
817+
, Z_STRLEN_PP(data), Z_STRVAL_PP(data), Z_STRLEN_PP(data));
816818
if(old_cmd) {
817819
efree(old_cmd);
818820
}
821+
elements++;
819822
}
820823
}
821824

822825
old_cmd = cmd;
823-
cmd_len = spprintf(&cmd, 0, "MGET %s\r\n", cmd);
824-
826+
cmd_len = redis_cmd_format(&cmd, "*%d" _NL "$4" _NL "MGET" _NL "%s", elements, cmd, cmd_len);
825827
efree(old_cmd);
826828

827829
REDIS_PROCESS_REQUEST(redis_sock, cmd, cmd_len);

0 commit comments

Comments
 (0)