Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very weak KNN #2

Open
ReaperZ0v opened this issue Jan 10, 2019 · 2 comments
Open

Very weak KNN #2

ReaperZ0v opened this issue Jan 10, 2019 · 2 comments

Comments

@ReaperZ0v
Copy link

Hi, nice project on the KNN algorithm but could you make the algorithm a bit more obscure and expandable? why not use library like sklearn ? feel free to check out my kNN repository! also give the user options for input...

cheers!
@div3125
Copy link
Owner

div3125 commented Jan 11, 2019

I did not use sklearn on purpose. I implemented this as I was trying to understand how KNN actually works under the hood of abstractions such as fit() and predict() methods provided by sklearn. Still, the code could use some refactoring, I'll work on it.

@ReaperZ0v
Copy link
Author

oh I get it meaning actually to use loops and functions to make the functions of KNN work without libraries ? that's cool then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@div3125 @ReaperZ0v