Skip to content

Commit 379ddf9

Browse files
committed
Merge pull request ExactTarget#118 from djmccormick/issue75
Resolved Issue #75.
2 parents 682c6c4 + 0847859 commit 379ddf9

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

src/spinner.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,8 @@ define(function(require) {
134134
},
135135

136136
value: function (value) {
137-
if (typeof value !== 'undefined') {
137+
if (!isNaN(parseFloat(value)) && isFinite(value)) {
138+
value = parseFloat(value);
138139
this.options.value = value;
139140
this.$input.val(value);
140141
return this;
@@ -197,4 +198,4 @@ define(function(require) {
197198
});
198199
});
199200

200-
});
201+
});

test/spinner-test.js

+11-4
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,16 @@ require(['jquery', 'fuelux/spinner'], function($) {
3030
//returning default value
3131
equal($spinner.spinner('value'), 1, 'spinner returns selected item');
3232

33-
//set value
33+
//set number value
3434
$spinner.spinner('value',2);
35-
equal($spinner.spinner('value'), 2, 'spinner sets value');
35+
equal($spinner.spinner('value'), 2, 'spinner sets number value');
36+
37+
//set numeric string value
38+
$spinner.spinner('value','2.1');
39+
equal($spinner.spinner('value'), 2.1, 'spinner sets floating point numeric string value');
40+
41+
$spinner.spinner('value','2');
42+
equal($spinner.spinner('value'), 2, 'spinner sets integer numeric string value');
3643

3744
//disable
3845
$spinner.spinner('disable');
@@ -45,7 +52,7 @@ require(['jquery', 'fuelux/spinner'], function($) {
4552
//change
4653
$spinner.spinner('value','b2');
4754
$spinner.spinner('change');
48-
equal($spinner.spinner('value'), 2, 'spinner change working for numbers only');
55+
equal($spinner.spinner('value'), 2, 'spinner change not working for alpha strings');
4956

5057
//increment positive
5158
$spinner.spinner('step',true);
@@ -63,4 +70,4 @@ require(['jquery', 'fuelux/spinner'], function($) {
6370
equal($spinner.spinner('value'), 0, 'spinner value was set to zero');
6471
});
6572

66-
});
73+
});

0 commit comments

Comments
 (0)