Skip to content

Commit 1ec6ed5

Browse files
author
Amit Patankar
authoredApr 21, 2017
Merge pull request tensorflow#9351 from av8ramit/cherrypicks
TensorBoard Cherrypick
2 parents b728b74 + fa25fcb commit 1ec6ed5

File tree

2 files changed

+2
-18
lines changed

2 files changed

+2
-18
lines changed
 

‎tensorflow/tensorboard/components/tf_dashboard_common/tf-multi-checkbox.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,7 @@
183183
// if undefined, default value (enable for first k runs, disable after).
184184
type: Object,
185185
value: TF.URIStorage.getObjectInitializer('runSelectionState', {}),
186+
observer: "_storeRunToIsCheckedMapping",
186187
},
187188
// (Allows state to persist across regex filtering)
188189
outSelected: {
@@ -230,7 +231,6 @@
230231
},
231232
observers: [
232233
"_setIsolatorIcon(runSelectionState, names)",
233-
"_storeRunToIsCheckedMapping(runSelectionState)",
234234
],
235235
_storeRunToIsCheckedMapping: TF.URIStorage.getObjectObserver('runSelectionState', {}),
236236
_makeRegex: function(regex) {

‎tensorflow/tensorboard/dist/tf-tensorboard.html

+1-17
Original file line numberDiff line numberDiff line change
@@ -3325,6 +3325,7 @@ <h3>[[name]]</h3>
33253325
// if undefined, default value (enable for first k runs, disable after).
33263326
type: Object,
33273327
value: TF.URIStorage.getObjectInitializer('runSelectionState', {}),
3328+
observer: "_storeRunToIsCheckedMapping",
33283329
},
33293330
// (Allows state to persist across regex filtering)
33303331
outSelected: {
@@ -3373,24 +3374,7 @@ <h3>[[name]]</h3>
33733374
},
33743375
observers: [
33753376
"_setIsolatorIcon(runSelectionState, names)",
3376-
"_storeRunToIsCheckedMappingWithDefault(runSelectionState, namesMatchingRegex)",
33773377
],
3378-
_storeRunToIsCheckedMappingWithDefault() {
3379-
var runSelectionStateIsDefault = Object.keys(this.runSelectionState).length == 0;
3380-
if (runSelectionStateIsDefault || this.namesMatchingRegex == null) {
3381-
return;
3382-
}
3383-
var _this = this;
3384-
var allToggledOn = this.namesMatchingRegex
3385-
.every(function(n) {return _this.runSelectionState[n]});
3386-
var allToggledOff = this.namesMatchingRegex
3387-
.every(function(n) {return !_this.runSelectionState[n]});
3388-
var defaultOff = this.namesMatchingRegex.length > this.maxRunsToEnableByDefault;
3389-
if (defaultOff && allToggledOff || !defaultOff && allToggledOn) {
3390-
this.runSelectionState = {};
3391-
}
3392-
this._storeRunToIsCheckedMapping(this.runSelectionState);
3393-
},
33943378
_storeRunToIsCheckedMapping: TF.URIStorage.getObjectObserver('runSelectionState', {}),
33953379
_makeRegex: function(regex) {
33963380
try {

0 commit comments

Comments
 (0)
Please sign in to comment.