Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent mapping types in extensions #2838

Open
mbabker opened this issue Jul 8, 2024 · 0 comments
Open

Inconsistent mapping types in extensions #2838

mbabker opened this issue Jul 8, 2024 · 0 comments

Comments

@mbabker
Copy link
Contributor

mbabker commented Jul 8, 2024

Two things I'm noticing:

  1. The supported mapping types aren't consistent in the extension mapping drivers, sluggable being the worst of it as the attribute driver supports a lot more field types than the XML or YAML drivers, which leads into...

  2. The supported mapping types are generally duplicated for each mapping driver, except for the soft-deleteable extension which has a static helper used by all mappings (and it uses a public static array to check against, meaning downstream users could technically make this whatever they want!)

It'd be good to get the supported field mapping types for each extension consolidated and consistent unless there is a valid reason why datetime_immutable is only supported for attribute mapping when using the sluggable extension 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant