Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-check date/time mapping support for immutable types #2839

Open
mbabker opened this issue Jul 8, 2024 · 0 comments
Open

Double-check date/time mapping support for immutable types #2839

mbabker opened this issue Jul 8, 2024 · 0 comments

Comments

@mbabker
Copy link
Contributor

mbabker commented Jul 8, 2024

Scanning for "datetime" in the extensions, there are a couple of places where there are lists of date-related mapping types checked for different features:

  • Gedmo\Translatable\Query\TreeWalker\TranslationWalker checks for the mutable types but doesn't check the immutable counterparts
  • Gedmo\Tree\Mapping\Validator::isValidFieldForLockTime() only supports mutable types for the lock time

Unless there's a strong reason to only support the mutable variant, the immutable types should probably be supported as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant