Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser support for adding/removing partition #8744

Closed
okhowang opened this issue Jan 7, 2025 · 3 comments · Fixed by dolthub/vitess#394
Closed

Parser support for adding/removing partition #8744

okhowang opened this issue Jan 7, 2025 · 3 comments · Fixed by dolthub/vitess#394

Comments

@okhowang
Copy link

okhowang commented Jan 7, 2025

partition syntax has been supported in dolthub/go-mysql-server#2472.
but adding/removing partition remain error in parser.

alter table a partition by hash ( id );
alter table a remove partitioning ;
@fulghum
Copy link
Contributor

fulghum commented Jan 9, 2025

Hi @okhowang, thanks for taking the time to report this. Adding parser support for this syntax in our fork of vitess should be pretty straightforward. We're all focused on other tasks currently, but we'll see if we can knock this one out quickly as we get some open time. If anyone is looking to make a contribution, this is a pretty good one to start with, and we're happy to provide pointers.

@max-hoffman max-hoffman transferred this issue from dolthub/go-mysql-server Jan 14, 2025
@max-hoffman
Copy link
Contributor

@jycor would this one take long to knock out?

@jycor jycor changed the title Parser support for adding/removing parition Parser support for adding/removing partition Jan 15, 2025
@jycor
Copy link
Contributor

jycor commented Jan 15, 2025

Hey @okhowang, the fix for this has been merged to dolt main. We'll have a release out with the fix later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants