-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling arm64 support #1130
Comments
I identified another work item. https://github.com/dorssel/usbipd-win/tree/master/Usbipd/WSL contains a pre-built (x64!) statically linked distro-independent |
Nice catch, we noticed this when attempting to test end to end. Hadn't had a chance to dig in, but I've updated the issue to add this. |
I've built a statically linked distro-independent (using the libudev-zero project as described in the WSL README)
Shall I email it to you so you can upload it as an artifact? or just open a MR for adding it to the project? |
@dorssel re: usbip - if you want help setting up this a proper project to produce the builds for x64/arm64 let me know, happy to help out. |
Already have a private repo that does this for x64. Will publish soon. Don't know if it can be used to cross-compile for ARM64 (public Linux GitHub bots are native x64). But the build steps will be the same, so it can easily be repeated on an ARM64 Linux distro, just not automated. |
Whoops, I missed that you've already done this. Great!
Just open a PR. I don't want to clobber the build pipeline for |
Got it, will do. We are going to do some end to end testing today and if everything looks good I will send the PR. Once you open the project up, I'm happy to send a PR to enable cross compilation or I can offer a native ARM64 github runner. Whatever your preference is, I'm ok with. |
I'll just make the projects MultiTarget. Cross-compilation of C# is a breeze. NativeAOT for ARM64 should also work, even on x64. Then we can make 2 proper MSIs, one for each target. I guess you are running |
Ok sounds good to me. Yes, right now we are running I'm going to start working on the changes needed to build the arm64 MSI, but I have some questions :) Do you have instructions for building this project? I checked on the wiki, but didn't find anything. The reason I ask is that I'm not used to building on Windows but I want to make sure I'm using the right tools. Right now I have:
This can produce the x64 installer msi, but I don't see a way to generate new target configurations (i.e. arm64) without manually editing the Does this seem like the right environment? Or another path you would recommend? |
We have confirmation from the team with the drivers merged in #1132 and the |
w00t w00t! I'm well on the way making the |
Quick one on the My idea was to create architecture specific directories for each Let me know what approach you'd like to take and I'll submit the PR. |
Yep, same trick as before. Move the current binary into a subdirect x64 here https://github.com/dorssel/usbipd-win/tree/master/Usbipd/WSL. And then add the ARM one. This time I'll let the publishing fix it, like here: https://github.com/dorssel/usbipd-win/blob/master/Usbipd/Usbipd.csproj#L45-L49 WiX won't even know about it... |
Done, see #1136 |
@AndreasKunar you'll need to disable signing by running the command below in admin mode, and reboot before running the installer (until we fix that issue)
|
Still WIP (not the right pin on the WSL version), no README, etc.) But here is the project https://github.com/dorssel/usbipd-win-wsl/ Artifacts (again: not the right version yet) example: https://github.com/dorssel/usbipd-win-wsl/actions/runs/13358929116 Bonus: no "diff" anymore, just the right build options. See the build action. |
@EmbeddedAndroid |
Perfect, looks great to me. Thanks! |
Quick update on the driver signing. We have signed drivers internally. I've built the installer with those drivers internally for us to perform some validation on. A discussion ongoing about who the right entity should be to do the signing for the drivers released in this project. Once that concludes, we will get them added here asap. Sorry for the delay! |
I'd like to open this issue to track the progress of adding ARM64 support to this project. @dorssel and I spoke last week about getting this supported in the project, and this is the follow up.
Issues to resolve:
usbipd list
shows connected usb devices on arm64Proposal:
bcdedit.exe /set testsigning on
Please let me know your thoughts on this approach and any feedback you may have.
The text was updated successfully, but these errors were encountered: