Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design System: Primary Opacity 10 color is missing #30959

Closed
zJaaal opened this issue Dec 17, 2024 · 2 comments · Fixed by #30964
Closed

Design System: Primary Opacity 10 color is missing #30959

zJaaal opened this issue Dec 17, 2024 · 2 comments · Fixed by #30964
Assignees
@dsilvam @nicobytes
Labels
OKR : User Experience Owned by Jason Priority : 3 Average QA : Passed Internal Release : 25.01.15 Team : Falcon Type : Defect

Comments

@zJaaal
Copy link
Contributor

zJaaal commented Dec 17, 2024 •
edited
Loading

Problem Statement

The color-palette-primary-op-10 var in our Design System is self referencing in the code, leading to a not defined color and missing color states in some components

Steps to Reproduce

Screen.Recording.2024-12-17.at.1.mp4

Acceptance Criteria

  • Design System variables should be defined at any point of our application and apply the expected styles

dotCMS Version

latest-trunk

Proposed Objective

User Experience

Proposed Priority

Priority 3 - Average

Assumptions & Initiation Needs

  • You understand how the Design System variables get populated in DotCMS
@zJaaal zJaaal moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Dec 17, 2024
@nicobytes nicobytes linked a pull request Dec 17, 2024 that will close this issue
fix(scss): fix error with hover #30964
Merged
3 tasks
@nicobytes nicobytes mentioned this issue Dec 17, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

PRs:

@nicobytes nicobytes moved this from Next 1-3 Sprints to In Review in dotCMS - Product Planning Dec 17, 2024
@nicobytes nicobytes removed the Triage label Dec 17, 2024
@nicobytes nicobytes self-assigned this Dec 17, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 17, 2024
@nicobytes
fix(scss): fix error with hover (#30964)
bafccb3 
### Parent Issue

#30959 

### Proposed Changes

This pull request includes changes to the
`core-web/libs/dotcms-scss/shared/_colors.scss` file to improve the
color accessibility and consistency in the codebase.

Improvements to color accessibility:

* Changed the value of `--color-palette-primary-op-10` to use `hsla`
with a specific lightness and opacity, ensuring better color
accessibility.

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Screenshots

<img width="395" alt="Screenshot 2024-12-17 at 3 56 40 PM"
src="https://github.com/user-attachments/assets/114b53dd-ae91-4cc2-b477-f25972cf67d5"
/>
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Dec 17, 2024
@dsilvam dsilvam reopened this Jan 8, 2025
@github-project-automation github-project-automation bot moved this from Done to Current Sprint Backlog in dotCMS - Product Planning Jan 8, 2025
@dsilvam dsilvam moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Jan 8, 2025
@dsilvam dsilvam self-assigned this Jan 13, 2025
@dsilvam
Copy link
Contributor

dsilvam commented Jan 14, 2025

Passed IQA: Hover showing as expected.

Image Image

@dsilvam dsilvam moved this from Internal QA to Done in dotCMS - Product Planning Jan 14, 2025
@dsilvam dsilvam closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsilvam dsilvam

@nicobytes nicobytes

Labels
OKR : User Experience Owned by Jason Priority : 3 Average QA : Passed Internal Release : 25.01.15 Team : Falcon Type : Defect
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(scss): fix error with hover dotCMS/core
4 participants
@dsilvam @nicobytes @nollymar @zJaaal