ArgumentOutOfRangeException is also thrown when setting HttpClient.Timeout to more than 24 days

[datvm]

Type of issue

Missing information

Description

ArgumentOutOfRangeException
The timeout specified is less than or equal to zero and is not InfiniteTimeSpan.

From the source code, it actually throws when you put in value greater than about 24 days (int.MaxValuems) too:

private static readonly TimeSpan s_maxTimeout = TimeSpan.FromMilliseconds(int.MaxValue);
// ...
        public TimeSpan Timeout
        {
            get => _timeout;
            set
            {
                if (value != s_infiniteTimeout)
                {
                    ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(value, TimeSpan.Zero);
                    ArgumentOutOfRangeException.ThrowIfGreaterThan(value, s_maxTimeout);
                }
                CheckDisposedOrStarted();
                _timeout = value;
            }
        }

I encountered this issue when trying to set it to TimeSpan.MaxValue:

System.ArgumentOutOfRangeException: value ('10675199.02:48:05.4775807') must be less than or equal to '24.20:31:23.6470000'. (Parameter 'value')

Page URL

https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclient.timeout?view=net-9.0

Content source URL

https://github.com/dotnet/dotnet-api-docs/blob/main/xml/System.Net.Http/HttpClient.xml

Document Version Independent Id

199a48e3-16ed-9fe0-8957-f14f37a17acd

Article author

@karelz

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/ncl

[ManickaP]

If you want "unlimited" timeout, you should use Timeout.InfiniteTimeSpan which is technically -1 ms.
BTW, the same documentation issue is with MaxResponseContentBufferSize as well.

We'd gladly take a contribution to the docs to fix these.

[rzikm]

Btw. technical limitation for this is due to https://learn.microsoft.com/en-us/dotnet/api/system.threading.cancellationtokensource.cancelafter?view=net-9.0

ArgumentOutOfRangeException
delay.TotalMilliseconds is less than -1 or greater than Int32.MaxValue (or UInt32.MaxValue - 1 on some versions of .NET). Note that this upper bound is more restrictive than TimeSpan.MaxValue.