Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wasm][AOT] methods with try/catch/finally blocks are not AOTed #111281

Open
jeromelaban opened this issue Jan 10, 2025 · 1 comment
Open

[Wasm][AOT] methods with try/catch/finally blocks are not AOTed #111281

jeromelaban opened this issue Jan 10, 2025 · 1 comment
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono os-browser Browser variant of arch-wasm
Milestone

Comments

@jeromelaban
Copy link
Contributor

jeromelaban commented Jan 10, 2025

Description

Related to the work in #56309, the AOT compiler is skipping methods containing try/catch/finally blocks, specifically. try/finally and try/catch blocks are AOTed properly.

This causes those specific methods to be executed by the interpreter, therefore being slow.

Reproduction Steps

Build and run the following repro: 20250110-issue-111281-ehissue02.zip

The output looks as follows in the profiler:

Image

Where the last method should be be entering the interpreter to execute.

Expected behavior

No interpreter is used to execute any of the methods defined by the user when a try/catch/finally pattern is used.

Actual behavior

See above.

Regression?

No. Related to #78653.

Known Workarounds

Split the methods so that one contains a try/finally, and the other a try/catch, if possible.

Configuration

9.0.100

Other information

No response

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 10, 2025
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jan 10, 2025
@steveisok steveisok added os-browser Browser variant of arch-wasm arch-wasm WebAssembly architecture labels Jan 10, 2025
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@steveisok steveisok added area-Codegen-AOT-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 10, 2025
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jan 10, 2025
@lewing lewing added this to the 10.0.0 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

No branches or pull requests

3 participants