Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential buffer overflow #14

Open
adamblack1 opened this issue Nov 14, 2014 · 2 comments
Open

Potential buffer overflow #14

adamblack1 opened this issue Nov 14, 2014 · 2 comments

Comments

@adamblack1
Copy link

/src/CSlim/SlimList.c
char* SlimList_ToString(SlimList* self)

this function continually appends up to an additional 128 characters to buf. If buf already contains 127 characters this will still append more characters to the string.

@dougbradbury
Copy link
Owner

Thanks @adamblack1 for your code review. Do you have any interest in submitting a pull request to address these issues? I can work with you on the process if you are interested

@adamblack1
Copy link
Author

@dougbradbury thank you for mentioning the idea of a pull request. I have created a pull request (#17) I look forward to hearing any feedback that you have.

dougbradbury added a commit that referenced this issue Mar 13, 2015
Fix "Potential buffer overflow #14" (SlimList_ToString), Performance improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants