Skip to content

--g-fatal-warnings option should remove "REAL" from the last arguments #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osayama opened this issue Jul 20, 2016 · 0 comments
Open

Comments

@osayama
Copy link

osayama commented Jul 20, 2016

In 20151223 version of paps, I got the following issue.

paps -h and paps's man pages describe '--g-fatal-warnings' differently

paps.1 man page haven't described about '--g-fatal-warnings' yet but
we are applying the following patch for paps.1 so this issue was raised.

https://github.com/dov/paps/pull/18/commits/4be7c77077cefedf9b000a85cdaf8621700f577a

I checked that paps.c and it looks to me that updated man page is
right because do_fatal_warnings is defined as gboolean. So I think
paps.c should remove "REAL" from the last arguments.

% ./paps --help |& grep g-fatal-warnings
--g-fatal-warnings=REAL Set glib fatal warnings
% grep do_fatal_warnings paps.c
gboolean do_fatal_warnings = FALSE;
{"g-fatal-warnings", 0, 0, G_OPTION_ARG_NONE, &do_fatal_warnings,
if (do_fatal_warnings)
% gdiff -u paps.c.org paps.c
--- paps.c.org 2016-07-20 09:21:33.529764313 +0900
+++ paps.c 2016-07-20 09:22:32.614399477 +0900
@@ -510,7 +510,7 @@
N_("Stretch characters in y-direction to fill lines."), NULL},
*/
{"g-fatal-warnings", 0, 0, G_OPTION_ARG_NONE, &do_fatal_warnings,

  • N_("Set glib fatal warnings"), "REAL"},
    
  • N_("Set glib fatal warnings"), NULL},
    
    {NULL}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant