Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely slow tests when comparing screenshots of different sizes #13

Closed
JoseAlcerreca opened this issue Jun 17, 2022 · 1 comment · Fixed by #17
Closed

Extremely slow tests when comparing screenshots of different sizes #13

JoseAlcerreca opened this issue Jun 17, 2022 · 1 comment · Fixed by #17

Comments

@JoseAlcerreca
Copy link
Contributor

Consider checking the size and fail immediately. Since the comparison is made on device, a slow emulator can take a long time (I'm getting 37s per test).

We would lose the 3-way diff I assume.

@rharter
Copy link
Collaborator

rharter commented Jun 28, 2022

The diff performance is dependent on the number of pixels that need to be compared, which ends up being a lot when the images are completely different. This is a mix of comparing things that we already know aren't the right size, but also of the default configuration of the image comparator, which uses a large shift window that multiplies the number of compares that are needed. I'll be fixing this in two parts in the coming PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants