Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller Attributes #1002

Open
SimonRubenDrauz opened this issue Nov 20, 2020 · 0 comments
Open

Controller Attributes #1002

SimonRubenDrauz opened this issue Nov 20, 2020 · 0 comments
Assignees

Comments

@SimonRubenDrauz
Copy link
Contributor

The basic controller class contains three atrributes I would recommend to remove from there: initial_run, index and recycle. Instead I would move them to the net.controller-DataFrame. recycle and index are already there, initial_run I would also add.

Following reason: Right now index and recycle have been declared twice: once in the controller class and once in the net.controller-DataFrame. That means, if I change one of them in the aftermath of the initialization, they would be suddenly incosistent. I guess the controller-attribute is the leading parameter, therefore everything in the DataFrame is ignored (even if the user changes it).

What do you think? If you agree, I would change it and create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants