You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The basic controller class contains three atrributes I would recommend to remove from there: initial_run, index and recycle. Instead I would move them to the net.controller-DataFrame. recycle and index are already there, initial_run I would also add.
Following reason: Right now index and recycle have been declared twice: once in the controller class and once in the net.controller-DataFrame. That means, if I change one of them in the aftermath of the initialization, they would be suddenly incosistent. I guess the controller-attribute is the leading parameter, therefore everything in the DataFrame is ignored (even if the user changes it).
What do you think? If you agree, I would change it and create a PR.
The text was updated successfully, but these errors were encountered:
The basic controller class contains three atrributes I would recommend to remove from there: initial_run, index and recycle. Instead I would move them to the net.controller-DataFrame. recycle and index are already there, initial_run I would also add.
Following reason: Right now index and recycle have been declared twice: once in the controller class and once in the net.controller-DataFrame. That means, if I change one of them in the aftermath of the initialization, they would be suddenly incosistent. I guess the controller-attribute is the leading parameter, therefore everything in the DataFrame is ignored (even if the user changes it).
What do you think? If you agree, I would change it and create a PR.
The text was updated successfully, but these errors were encountered: