Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading comment #26

Closed
gdims opened this issue Mar 31, 2021 · 0 comments · Fixed by #28
Closed

Misleading comment #26

gdims opened this issue Mar 31, 2021 · 0 comments · Fixed by #28

Comments

@gdims
Copy link

gdims commented Mar 31, 2021 •
edited
Loading

In echo.py, function getitem, line 247, there is a comment:

# Select random clips
        video = tuple(video[:, s + self.period * np.arange(length), :, :] for s in start)

This is not correct, as whether the clips are random or not has been specified in an earlier part of the code (lines 203 to 208).
bryanhe added a commit to bryanhe/dynamic that referenced this issue Apr 19, 2021
@bryanhe
Documentation (echonet/dynamic#26)
154bcf1
@bryanhe bryanhe mentioned this issue Apr 20, 2021
Merged
byebrid pushed a commit to DeepNeuron-AI/dynamic that referenced this issue May 29, 2023
@bryanhe
Documentation (echonet/dynamic#26)
20a9c09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Command line interface and bug fixes bryanhe/dynamic
1 participant
@gdims