Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enum approach in builder options to make default, disabled, custom arguments clearer #556

Open
elfenpiff opened this issue Dec 19, 2024 · 0 comments

Comments

@elfenpiff
Copy link
Contributor

Brief feature description

Currently, service QoS settings can be handled by:

  1. explicitly stating them and make them a requirement when a service is opened
  2. not stating them and implicitly use the default values used by the service.

The idea is to introduce some kind of enum to make this more visible in the API.

let service = node.service_builder().some_setting(SettingEnum::Default).another_setting(SettingEnum::Require(123).create();

This issue originated from the discussion: #552 (comment)

@elfenpiff elfenpiff mentioned this issue Dec 19, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant