Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel TCP_NODELAY #2

Open
reiyawea opened this issue Oct 2, 2024 · 2 comments
Open

Cancel TCP_NODELAY #2

reiyawea opened this issue Oct 2, 2024 · 2 comments

Comments

@reiyawea
Copy link

reiyawea commented Oct 2, 2024

In tcp.c, line 35, setting TCP_NODELAY will make the TCP stack on the remote device (e.g. ESP8266) too busy with memory allocation and other things. I suggest to disable it and let TCP stack choose its own pace.

@eeyrw
Copy link
Owner

eeyrw commented Oct 3, 2024

It sounds quite reasonable. I used TCP_NODELAY flag merely for reducing latency, which I did a quick search on stackoverflow that said so. I have no idea of the side effect when interfacing low resource platform such as ESP8266 or other MCUs when TCP_NODELAY flag applied on PC side. You are welcome to modify the flag and create PR. By the way, this project is too old and I am not quite sure whether it still works in recent days.

@reiyawea
Copy link
Author

reiyawea commented Oct 4, 2024

Although a bit old, your DLL is now included in the official LCD smartie release and still works fine. Many thanks for your creation, which allows me to get rid of the serial cable.
I'm suffering with TCP_NODELAY when I create my own VFD display project and the ESP8266 frequently freezes and reboots due to WDT timeout. I suspect that TCP_NODELAY is messing up the TCP stack on the ESP8266.
By the way, I'm not using the native C++ SDK, but Micropython, whose slowness may be causing this problem. I'll switch to C++ and see if that fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants