pg_dump: suppress "Tablespace:" comment for default tablespaces

bmomjian · bmomjian · commit c71e273402bb · 2015-05-11T11:45:43.000-04:00
Report by Hans Ginzel
diff --git a/src/bin/pg_dump/pg_backup_archiver.c b/src/bin/pg_dump/pg_backup_archiver.c
@@ -3246,7 +3246,7 @@ _printTocEntry(ArchiveHandle *AH, TocEntry *te, RestoreOptions *ropt, bool isDat
 		free(sanitized_schema);
 		free(sanitized_owner);
 
-		if (te->tablespace && !ropt->noTablespace)
+		if (te->tablespace && strlen(te->tablespace) > 0 && !ropt->noTablespace)
 		{
 			char	   *sanitized_tablespace;
 

Original file line number	Diff line number	Diff line change
`@@ -3246,7 +3246,7 @@ _printTocEntry(ArchiveHandle AH, TocEntry te, RestoreOptions *ropt, bool isDat`
`3246`	`3246`	`free(sanitized_schema);`
`3247`	`3247`	`free(sanitized_owner);`
`3248`	`3248`
`3249`		`- if (te->tablespace && !ropt->noTablespace)`
	`3249`	`+ if (te->tablespace && strlen(te->tablespace) > 0 && !ropt->noTablespace)`
`3250`	`3250`	`{`
`3251`	`3251`	`char *sanitized_tablespace;`
`3252`	`3252`