Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] QueryBuilderBWCIT testQueryBuilderBWC {p0=UPGRADED} failing #116989

Closed
elasticsearchmachine opened this issue Nov 18, 2024 · 15 comments · Fixed by #119669
Closed

[CI] QueryBuilderBWCIT testQueryBuilderBWC {p0=UPGRADED} failing #116989

elasticsearchmachine opened this issue Nov 18, 2024 · 15 comments · Fixed by #119669
Assignees
Labels
needs:risk Requires assignment of a risk label (low, medium, blocker) :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 18, 2024

Build Scans:

Reproduction Line:

./gradlew ":x-pack:qa:full-cluster-restart:v8.6.2#bwcTest" -Dtests.class="org.elasticsearch.xpack.restart.QueryBuilderBWCIT" -Dtests.method="testQueryBuilderBWC {p0=UPGRADED}" -Dtests.seed=B33306C723CFDAB2 -Dtests.bwc=true -Dtests.locale=zgh-MA -Dtests.timezone=Europe/Busingen -Druntime.java=23

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.io.EOFException: null

Issue Reasons:

  • [main] 3 consecutive failures in step 8.6.2_bwc
  • [main] 3 consecutive failures in step 8.0.1_bwc
  • [main] 3 consecutive failures in step 8.3.3_bwc
  • [main] 3 consecutive failures in step 8.7.1_bwc
  • [main] 3 consecutive failures in step 8.4.3_bwc
  • [main] 3 consecutive failures in step 8.5.3_bwc
  • [main] 3 consecutive failures in step 8.2.3_bwc
  • [main] 3 consecutive failures in step 8.1.3_bwc
  • [main] 24 failures in test testQueryBuilderBWC {p0=UPGRADED} (4.7% fail rate in 509 executions)
  • [main] 3 failures in step 8.6.2_bwc (100.0% fail rate in 3 executions)
  • [main] 3 failures in step 8.0.1_bwc (100.0% fail rate in 3 executions)
  • [main] 3 failures in step 8.3.3_bwc (100.0% fail rate in 3 executions)
  • [main] 3 failures in step 8.7.1_bwc (100.0% fail rate in 3 executions)
  • [main] 3 failures in step 8.4.3_bwc (100.0% fail rate in 3 executions)
  • [main] 3 failures in step 8.5.3_bwc (100.0% fail rate in 3 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.

@elasticsearchmachine elasticsearchmachine added :Delivery/Build Build or test infrastructure >test-failure Triaged test failures from CI labels Nov 18, 2024
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 6 failures in test testQueryBuilderBWC {p0=UPGRADED} (1.1% fail rate in 539 executions)
  • [main] 2 failures in step 8.17.0_bwc-snapshots (1.5% fail rate in 135 executions)
  • [main] 2 failures in step 8.16.1_bwc-snapshots (1.4% fail rate in 147 executions)
  • [main] 3 failures in pipeline elasticsearch-pull-request (2.3% fail rate in 129 executions)

Build Scans:

@elasticsearchmachine elasticsearchmachine added Team:Delivery Meta label for Delivery team needs:risk Requires assignment of a risk label (low, medium, blocker) labels Nov 18, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-delivery (Team:Delivery)

rjernst pushed a commit to rjernst/elasticsearch that referenced this issue Nov 20, 2024
@mark-vieira mark-vieira added :Search Foundations/Search Catch all for Search Foundations and removed :Delivery/Build Build or test infrastructure labels Nov 22, 2024
@mark-vieira
Copy link
Contributor

Looks to be the same as #116990

@elasticsearchmachine elasticsearchmachine added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Delivery Meta label for Delivery team labels Nov 22, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-search-foundations (Team:Search Foundations)

alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this issue Nov 28, 2024
@drempapis drempapis self-assigned this Nov 29, 2024
@drempapis
Copy link
Contributor

Investigated in the pr #117831

@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 3 consecutive failures in test testQueryBuilderBWC {p0=UPGRADED}
  • [main] 3 consecutive failures in step 8.5.3_bwc
  • [main] 3 consecutive failures in step 8.2.3_bwc
  • [main] 3 consecutive failures in step 8.1.3_bwc
  • [main] 2 consecutive failures in step 8.4.3_bwc
  • [main] 2 consecutive failures in step 8.6.2_bwc
  • [main] 2 consecutive failures in step 8.0.1_bwc
  • [main] 2 consecutive failures in step 8.7.1_bwc
  • [main] 2 consecutive failures in step 8.3.3_bwc
  • [main] 19 failures in test testQueryBuilderBWC {p0=UPGRADED} (3.9% fail rate in 486 executions)
  • [main] 3 failures in step 8.5.3_bwc (100.0% fail rate in 3 executions)
  • [main] 3 failures in step 8.2.3_bwc (100.0% fail rate in 3 executions)
  • [main] 3 failures in step 8.1.3_bwc (100.0% fail rate in 3 executions)
  • [main] 2 failures in step 8.4.3_bwc (100.0% fail rate in 2 executions)
  • [main] 2 failures in step 8.6.2_bwc (100.0% fail rate in 2 executions)

Build Scans:

@drempapis
Copy link
Contributor

Hey @thecoop, happy new year!

Can you please provide some feedback on this issue? Is it related to 116941

@thecoop
Copy link
Member

thecoop commented Jan 3, 2025

@drempapis I'm unclear what's going on here, or what I need to do. When did this start failing? Do you know what the problem is?

@drempapis
Copy link
Contributor

That started on November 18, and I supposed the cause was the boolean bwc_tests_enabled in elasticsearch/build.gradle did not flip the value before merging for 116941.

Debugging it locally, e.g., for v.8.5.3#bwcTest, I get an EOF when reading the input.

 QueryBuilder queryBuilder = input.readNamedWriteable(QueryBuilder.class);

Reverting the code when reading the transportVersion run successfully.

 transportVersion = TransportVersion.fromId(
                            parseLegacyVersion(getOldClusterVersion()).map(Version::id).orElse(TransportVersions.MINIMUM_COMPATIBLE.id())
                        );

@thecoop
Copy link
Member

thecoop commented Jan 3, 2025

QueryBuilderBWCIT needs to deserialize data from pre-8.18 nodes, even though v9 cannot communicate with <8.18 nodes?

@drempapis
Copy link
Contributor

The response seems truncated or has a deserialization mismatch when reading from input for < 8.18 nodes

@thecoop
Copy link
Member

thecoop commented Jan 3, 2025

So this test needs to deserialize data written by 8.0 nodes, even though the minimum version a 9.0 node can communicate with is 8.18?

@mark-vieira
Copy link
Contributor

So this test needs to deserialize data written by 8.0 nodes, even though the minimum version a 9.0 node can communicate with is 8.18?

Yes, because we support upgrades from 8.0 nodes if doing a full-cluster-restart, which is what this test is doing.

@thecoop thecoop self-assigned this Jan 7, 2025
@thecoop
Copy link
Member

thecoop commented Jan 7, 2025

Reinstated the check in #119669

@drempapis
Copy link
Contributor

Closing after the #119669 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:risk Requires assignment of a risk label (low, medium, blocker) :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants