Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] ES818HnswBinaryQuantizedVectorsFormatTests testRandomExceptions failing #119392

Closed
elasticsearchmachine opened this issue Dec 31, 2024 · 2 comments · Fixed by #119691
Closed

[CI] ES818HnswBinaryQuantizedVectorsFormatTests testRandomExceptions failing #119392

elasticsearchmachine opened this issue Dec 31, 2024 · 2 comments · Fixed by #119691
Assignees
@benwtrent
Labels
medium-risk An open issue or test failure that is a medium risk to future releases :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

Build Scans:

Reproduction Line:

null

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.RuntimeException: MockDirectoryWrapper: cannot close: there are still 1 open files: {_15_ES818HnswBinaryQuantizedVectorsFormat_0.veb_temp_42.tmp=1}

Issue Reasons:

  • [main] 2 failures in test testRandomExceptions (1.4% fail rate in 145 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Search Relevance/Vectors Vector search >test-failure Triaged test failures from CI needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Dec 31, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@benwtrent benwtrent added medium-risk An open issue or test failure that is a medium risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Jan 6, 2025
@benwtrent
Copy link
Member

Reproduction:

./gradlew test --tests ES818HnswBinaryQuantizedVectorsFormatTests.testRandomExceptions -Dtests.seed=A571E0850B9E4531 -Dtests.locale=ar-LY -Dtests.timezone=America/Guadeloupe -Dtests.asserts=true -Dtests.file.encoding=UTF-8

@benwtrent benwtrent self-assigned this Jan 7, 2025
@benwtrent benwtrent mentioned this issue Jan 7, 2025
Merged
elasticsearchmachine pushed a commit that referenced this issue Jan 8, 2025
@benwtrent
Fix bbq_hnsw merge file cleanup on random IO exceptions (#119691)
8edcdd4 
Since we open two temporary files during quantized vector merging, its
possible that the second file fails to be created. In that case, we
should ensure the previously created temporary files are removed.

closes #119392
benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Jan 8, 2025
@benwtrent
Fix bbq_hnsw merge file cleanup on random IO exceptions (elastic#119691)
20b1b3a 
Since we open two temporary files during quantized vector merging, its
possible that the second file fails to be created. In that case, we
should ensure the previously created temporary files are removed.

closes elastic#119392
elasticsearchmachine pushed a commit that referenced this issue Jan 8, 2025
@benwtrent
Fix bbq_hnsw merge file cleanup on random IO exceptions (#119691) (#1…
95c87fd 
…19763)

Since we open two temporary files during quantized vector merging, its
possible that the second file fails to be created. In that case, we
should ensure the previously created temporary files are removed.

closes #119392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benwtrent benwtrent

Labels
medium-risk An open issue or test failure that is a medium risk to future releases :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bbq_hnsw merge file cleanup on random IO exceptions benwtrent/elasticsearch
2 participants
@benwtrent @elasticsearchmachine