-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESQL: investigate Exceptions unwrapping in API #119692
Comments
Pinging @elastic/es-analytical-engine (Team:Analytics) |
After further consideration, the wrapping should remain in place, since it can be the only logged trace of an ESQL request failure. Without it, one would need to run ES on debug logging to get an indication of what's wrong. For a
producing a log entry:
But as a different example, a bug such as the query in #119950, produces a more verbose log entry:
|
This applies minor logging changes removing some duplication and making it obvious in the log message that the entry is produced by ESQL (EsqlResponseListener). It also removes some code duplication in the way query actions produce the RestChannelConsumer. Closes #119692.
This applies minor logging changes removing some duplication and making it obvious in the log message that the entry is produced by ESQL (EsqlResponseListener). It also removes some code duplication in the way query actions produce the RestChannelConsumer. Closes elastic#119692.
This applies minor logging changes removing some duplication and making it obvious in the log message that the entry is produced by ESQL (EsqlResponseListener). It also removes some code duplication in the way query actions produce the RestChannelConsumer. Closes #119692.
Description
ESQL wraps currently exceptions bubbled from downstream (afte change). We should look into ways of reverting this behavior, which would allow more accurate monitoring of the infrastructure and better pinpointing of failures.
The text was updated successfully, but these errors were encountered: