Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Profile should include row_count by default #119969

Open
nik9000 opened this issue Jan 10, 2025 · 1 comment
Open

ESQL: Profile should include row_count by default #119969

nik9000 opened this issue Jan 10, 2025 · 1 comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@nik9000
Copy link
Member

nik9000 commented Jan 10, 2025

Description

Our profiles look like:

            {
              "operator": "EvalOperator[evaluator=ConcatEvaluator[values=[ToStringFromLongEvaluator[field=Attribute[channel=4]], LiteralsEvaluator[lit=[3a]], ToStringFromLongEvaluator[field=CaseEagerEvaluator[conditions=[ConditionEvaluator[condition=EqualsKeywordsEvaluator[lhs=Attribute[channel=3], rhs=LiteralsEvaluator[lit=[73 70 61 6e]]], value=Attribute[channel=11]]], elseVal=Attribute[channel=12]]]]]]",
              "status": {
                "process_nanos": 84322048,
                "pages_processed": 480
              }
            },

It'd be really useful and cheap to include the number of positions processed. We could just positions += page.getPositionCount() and that's pretty close to free. A single extra + per page should be fine.

@nik9000 nik9000 added >enhancement needs:triage Requires assignment of a team area label :Analytics/ES|QL AKA ESQL labels Jan 10, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

2 participants