-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Replace the Download button for Elastic models by extending the Deploy action #195593
Comments
Pinging @elastic/ml-ui (:ml) |
To clarify, this will mean staying on this page until the download has completed (in order to trigger the deployment afterwards)? Or just |
@mdefazio just keeping the Kibana tab open, no need to stay on the Trained Models page. |
Awesome, thanks! I appreciate you setting this one up. |
This issue triggered a conversation about the number of deployments and some things that can be improved later on:
To be discussed further on. |
Elastic curated models can be downloaded directly from the Trained Models UI using a dedicated "Download" action. However, having a separate action is impractical since the user must deploy the model afterward, either for testing or production use. It would be more user-friendly to make the download part of the deployment process.
We should remove the download button and extend the "Start Deployment" action to trigger the model download if necessary.
Downloading a model, such as ELSER, may take several minutes depending on network bandwidth. This should be considered when optimizing the user experience.
There are two ways to address this issue:
Update Kibana's "Start Deployment" endpoint to PUT the model if needed, track the download status, and attempt to start the deployment with the requested parameters. This approach is more flexible, allowing the user to initiate the action and close the browser tab while Kibana handles the rest. However, it is more complex to implement, requires a background task, and introduces challenges in surfacing any errors back to the user.
Implement it as a UI feature only. In this case, the user would need to keep the browser tab open. The Trained Models page would track the download process and call the "Start Deployment" API afterward. This option is easier to implement, and error reporting is straightforward.
I believe we should consider the second option, as it reduces engineering overhead while still providing value to the user.
Later, we could consider utilizing the Service Worker API to track the download/deployment status and enable push notifications if the Kibana platform allows it.
The text was updated successfully, but these errors were encountered: