Fix for broken win push (#553)

Fixes #550 , our custom multi-asset plugin couldn't handle windows paths that start with C:\ and similar. Switched to FS agnostic code. The errors this caused were somewhat confusing because this only causes esbuild to fail later in its process with the message described in #550 .

Author: andrewvc

src/push/plugin.ts

@@ -49,8 +49,13 @@ export type PluginData = {
 export type PluginCallback = (data: PluginData) => void;
 
 export function MultiAssetPlugin(callback: PluginCallback): esbuild.Plugin {
+  // Check that the path isn't in an external package by making sure it's at a standard
+  // local filesystem location
   const isBare = (str: string) => {
-    if (str.startsWith('/') || str.startsWith('./') || str.startsWith('../')) {
+    // Note that we use `isAbsolute` to handle UNC/windows style paths like C:\path\to\thing
+    // This is not necessary for relative directories since `.\file` is not supported as an import
+    // nor is `~/path/to/file`.
+    if (path.isAbsolute(str) || str.startsWith('./') || str.startsWith('../')) {
       return true;
     }
     return false;