Using host-endian in mode instead of network byte order

[netrounds-alapaa]

Row 217 of client.c, the mode needs to be converted to network byte order before sending SetUpResponse to reflector. Verified by testing against Cisco TWAMP, a Cisco 890 router.

[zoidberg55]

Hi @netrounds-alapaa . Can you provide the code you used to correct this? I am trying to run this in my network and router keeps rejecting the sessions because of the byte ordering. Thanks!

[netrounds-alapaa]

Hi @zoidberg55 try something like this:

resp.Mode = htonl(greet.Modes & authmode);

[netrounds-oskar]

This is still a thing. Any TWAMP client using this reflector should always close the connection according to the RFC.

The mode field in the greeting is currently 01 00 00 00 but is supposed to be 00 00 00 01.

From the RFC (https://tools.ietf.org/html/rfc4656#section-3.1):

                                            The value of the Modes field
   sent by the server is the bit-wise OR of the mode values that it is
   willing to support during this session.  Thus, the last three bits of
   the Modes 32-bit value are used.  The first 29 bits MUST be zero. 

and

   If the Modes value is zero, the server does not wish to communicate
   with the client and MAY close the connection immediately.  The client
   SHOULD close the connection if it receives a greeting with Modes
   equal to zero. 

[kokakrishna]

Hi all, I have the code with correction. But forgot to send you all. I missed the thread. Please check the attached client code which is useful for you all. Just compile and check. I added support for “Timeout” under “Request-TW-Session” as well. Regards, Venkata Krishna From: zoidberg55 <[email protected]> Reply-To: emirica/twamp-protocol <[email protected]> Date: Wednesday, 23 November 2016 at 11:33 To: emirica/twamp-protocol <[email protected]> Cc: Koka Krishna <[email protected]>, Manual <[email protected]> Subject: Re: [emirica/twamp-protocol] Using host-endian in mode instead of network byte order (#8) Hi @netrounds-alapaa<https://github.com/netrounds-alapaa> . Can you provide the code you used to correct this? I am trying to run this in my network and router keeps rejecting the sessions because of the byte ordering. Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#8 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AToCdkaGd3jW6TnT6jEIXhVKxnMqNjEPks5rBBZggaJpZM4HmSix>.