Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extension data in emit_otlp #169

Open
KodrAus opened this issue Nov 10, 2024 · 2 comments
Open

Support extension data in emit_otlp #169

KodrAus opened this issue Nov 10, 2024 · 2 comments

Comments

@KodrAus
Copy link
Contributor

KodrAus commented Nov 10, 2024

emit's data model is intentionally smaller than OpenTelemetry's. There are some features in OpenTelemetry that emit isn't planning any direct support for, including:

  • span links
  • span kinds

We could still let you define your own scheme for these and pull them off events in emit_otlp to better tailor your diagnostics. It could use the same closure-based approach we do for overriding the span body:

emit::setup()
    .emit_to(emit_otlp::new()
        .traces(emit_otlp::traces_http_proto("..")
            .span_kind(|evt| evt.props().get("span_kind"))
    ));

For span links, we could just define our own SpanLink type in emit_otlp and allow you to map properties on the event into span links.

@KodrAus
Copy link
Contributor Author

KodrAus commented Jan 10, 2025

One more extension that would be good to figure out would be histograms in metrics.

@KodrAus KodrAus added the 1.0.0 label Jan 10, 2025
@KodrAus KodrAus removed the 1.0.0 label Feb 21, 2025
@KodrAus
Copy link
Contributor Author

KodrAus commented Feb 21, 2025

We can introduce extension data support without breaking changes so dropping this from 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant