Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline coordinate system with emg3d #132

Closed
prisae opened this issue Jul 17, 2021 · 2 comments
Closed

Streamline coordinate system with emg3d #132

prisae opened this issue Jul 17, 2021 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@prisae
Copy link
Member

prisae commented Jul 17, 2021

Currently, the coordinate system is quite flexible: RHS (positive z upwards) or LHS (positive z downwards), where depths can be increasing or decreasing:
https://empymod.emsig.xyz/en/stable/gallery/educational/coordinate_system.html

However, this has shown to be the source of a lot of confusion and many errors.

Streamline the coordinate system with emg3d, only one way how, RHS (positive z upwards):
https://emg3d.emsig.xyz/en/stable/manual/info.html#coordinate-system

What can be left flexible is if one defines the interfaces increasing or decreasing. E.g.

  • [-1000, -500, 0] or
  • [0, -500, -1000]
    The properties have to be provided in the same order.

Create a long deprecation cycle.

  • 1 year DeprecationWarning
  • 1 year FutureWarning
    or release v3.
@prisae prisae mentioned this issue Jul 17, 2021
4 tasks
@prisae prisae added the enhancement New feature or request label Jul 17, 2021
@prisae prisae pinned this issue Jul 17, 2021
@prisae
Copy link
Member Author

prisae commented Aug 2, 2021

Here the PR's where the "changes" were introduced:

So this will probably not change: It was implemented originally a bit awkwardly (LHS), but it was never changed. Changing this is likely to create more problems than it solves, is backwards incompatible, and will not change anything in the end.

Better documentation could always help though...

@prisae
Copy link
Member Author

prisae commented Aug 2, 2021

Potentially related: #133

@prisae prisae unpinned this issue Aug 2, 2021
@prisae prisae added the wontfix This will not be worked on label Aug 3, 2021
@prisae prisae closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant