Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Meta_Test_Suite_Tests can run on the CI #5275

Open
wdanilo opened this issue Feb 5, 2023 · 0 comments
Open

Ensure Meta_Test_Suite_Tests can run on the CI #5275

wdanilo opened this issue Feb 5, 2023 · 0 comments
Labels
-libs Libraries: New libraries to be implemented p-low Low priority x-chore Type: chore

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by Radosław Waśko.
Original issue is here.


The Meta_Test_Suite_Tests currently pass the enviornment variables to the children without any modifications.

Thus, if there is some test config defined for the parent test, it will be inherited by children. This is not correct - the tester should have control of what env vars are given to the children and should ensure they are consistent regardless of the parent's environment.

To do so, we need to extend System.create_process to allow to unset some environment variables. And possibly to also override some.

This way the runner will have control of child's env and will be able to run them predictably regardless of the external environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented p-low Low priority x-chore Type: chore
Projects
None yet
Development

No branches or pull requests

1 participant