Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_restart_features_allow_slot_destroy_on_worker_threads deprecation #38058

Closed
publish-envoy bot opened this issue Jan 16, 2025 · 0 comments · Fixed by #38071
Closed

envoy_restart_features_allow_slot_destroy_on_worker_threads deprecation #38058

publish-envoy bot opened this issue Jan 16, 2025 · 0 comments · Fixed by #38071
Assignees
@wbpcode
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@publish-envoy
Copy link
Contributor

publish-envoy bot commented Jan 16, 2025

Your change commit 86502cb (thread local: allow to destroy slot on worker thread) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wbpcode wbpcode

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: remove allow_slot_destroy_on_worker_threads runtime guard wbpcode/envoy
1 participant
@wbpcode