Skip to content

Commit 54337a9

Browse files
Jairo Llopischienandalu
Jairo Llopis
authored andcommitted
[FIX] mail_tracking: process sent events
Up until now, the `sent` event type was never processed, probably because it "made no sense", as an unsent email would never trigger an event. However, it makes sense to process it because you may have a local relay that transmits mails over to the mail provider. In those circumstances, you should have 2 "sent" events (one from the relay and another one from the provider). Also marked some useless parts of code for removal. @Tecnativa TT32365
1 parent 0184a0d commit 54337a9

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

mail_tracking/controllers/main.py

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ def _request_metadata(self):
4141
"ua_family": request.user_agent.browser or False,
4242
}
4343

44+
# TODO Remove useless controller
4445
@http.route(
4546
[
4647
"/mail/tracking/all/<string:db>",

mail_tracking/models/mail_tracking_email.py

+1
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,7 @@ def event_create(self, event_type, metadata):
385385
_logger.debug("Concurrent event '%s' discarded", event_type)
386386
return event_ids
387387

388+
# TODO Remove useless method
388389
@api.model
389390
def event_process(self, request, post, metadata, event_type=None):
390391
# Generic event process hook, inherit it and

mail_tracking/models/mail_tracking_event.py

+4
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,10 @@ def _process_bounce(self, tracking_email, metadata, event_type, state):
122122
)
123123
return self._process_data(tracking_email, metadata, event_type, state)
124124

125+
@api.model
126+
def process_sent(self, tracking_email, metadata):
127+
return self._process_status(tracking_email, metadata, "sent", "sent")
128+
125129
@api.model
126130
def process_delivered(self, tracking_email, metadata):
127131
return self._process_status(tracking_email, metadata, "delivered", "delivered")

0 commit comments

Comments
 (0)